Remove lazy records (#12682)

# Description
Removes lazy records from the language, following from the reasons
outlined in #12622. Namely, this should make semantics more clear and
will eliminate concerns regarding maintainability.

# User-Facing Changes
- Breaking change: `lazy make` is removed.
- Breaking change: `describe --collect-lazyrecords` flag is removed.
- `sys` and `debug info` now return regular records.

# After Submitting
- Update nushell book if necessary.
- Explore new `sys` and `debug info` APIs to prevent them from taking
too long (e.g., subcommands or taking an optional column/cell-path
argument).

crates/nu-plugin-core/src/util/with_custom_values_in.rs

@@ -2,8 +2,6 @@ use nu_protocol::{CustomValue, IntoSpanned, ShellError, Spanned, Value};
 
 /// Do something with all [`CustomValue`]s recursively within a `Value`. This is not limited to
 /// plugin custom values.
-///
-/// `LazyRecord`s will be collected to plain values for completeness.
 pub fn with_custom_values_in<E>(
     value: &mut Value,
     mut f: impl FnMut(Spanned<&mut Box<dyn CustomValue>>) -> Result<(), E>,
@@ -18,13 +16,6 @@ where
                 // Operate on a CustomValue.
                 f(val.into_spanned(span))
             }
-            // LazyRecord would be a problem for us, since it could return something else the
-            // next time, and we have to collect it anyway to serialize it. Collect it in place,
-            // and then use the result
-            Value::LazyRecord { val, .. } => {
-                *value = val.collect()?;
-                Ok(())
-            }
             _ => Ok(()),
         }
     })
@@ -33,31 +24,7 @@ where
 #[test]
 fn find_custom_values() {
     use nu_plugin_protocol::test_util::test_plugin_custom_value;
-    use nu_protocol::{engine::Closure, record, LazyRecord, Span};
-
-    #[derive(Debug, Clone)]
-    struct Lazy;
-    impl<'a> LazyRecord<'a> for Lazy {
-        fn column_names(&'a self) -> Vec<&'a str> {
-            vec!["custom", "plain"]
-        }
-
-        fn get_column_value(&self, column: &str) -> Result<Value, ShellError> {
-            Ok(match column {
-                "custom" => Value::test_custom_value(Box::new(test_plugin_custom_value())),
-                "plain" => Value::test_int(42),
-                _ => unimplemented!(),
-            })
-        }
-
-        fn span(&self) -> Span {
-            Span::test_data()
-        }
-
-        fn clone_value(&self, span: Span) -> Value {
-            Value::lazy_record(Box::new(self.clone()), span)
-        }
-    }
+    use nu_protocol::{engine::Closure, record};
 
     let mut cv = Value::test_custom_value(Box::new(test_plugin_custom_value()));
 
@@ -73,7 +40,6 @@ fn find_custom_values() {
                 captures: vec![(0, cv.clone()), (1, Value::test_string("foo"))]
             }
         ),
-        "lazy" => Value::test_lazy_record(Box::new(Lazy)),
     });
 
     // Do with_custom_values_in, and count the number of custom values found
@@ -83,7 +49,7 @@ fn find_custom_values() {
         Ok(())
     })
     .expect("error");
-    assert_eq!(4, found, "found in value");
+    assert_eq!(3, found, "found in value");
 
     // Try it on bare custom value too
     found = 0;