extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-30 22:50:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Plugins signature load (#349)

Browse Source 
* saving signatures to file

* loading plugin signature from file

* is_plugin column for help command
This commit is contained in:
Fernando Herrera
2021-11-19 02:51:42 +00:00
committed by GitHub
parent aa7226d5f6
commit 88988dc9f4
18 changed files with 215 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
crates/nu-parser/Cargo.toml
View File

@ -8,6 +8,7 @@ miette = "3.0.0"
thiserror = "1.0.29"
nu-protocol = { path = "../nu-protocol"}
nu-plugin = { path = "../nu-plugin", optional=true}
serde_json = "1.0"
nu-path = {path = "../nu-path"}
[features]

2
crates/nu-parser/src/errors.rs
View File

@ -192,6 +192,6 @@ pub enum ParseError {
FileNotFound(String),
#[error("Plugin error")]
#[diagnostic(code(nu::parser::export_not_found), url(docsrs))]
#[diagnostic(code(nu::parser::plugin_error), url(docsrs))]
PluginError(String),
}

26
crates/nu-parser/src/parse_keywords.rs
View File

@ -1085,6 +1085,8 @@ pub fn parse_plugin(
working_set: &mut StateWorkingSet,
spans: &[Span],
) -> (Statement, Option<ParseError>) {
use nu_protocol::Signature;
let name = working_set.get_span_contents(spans[0]);
if name != b"register" {
@ -1122,7 +1124,8 @@ pub fn parse_plugin(
// store declaration in working set
let plugin_decl =
PluginDeclaration::new(filename.clone(), signature);
working_set.add_decl(Box::new(plugin_decl));
working_set.add_plugin_decl(Box::new(plugin_decl));
}
None
@ -1135,8 +1138,27 @@ pub fn parse_plugin(
Some(ParseError::NonUtf8(spans[1]))
}
}
3 => {
let filename = working_set.get_span_contents(spans[1]);
let signature = working_set.get_span_contents(spans[2]);
if let Ok(filename) = String::from_utf8(filename.to_vec()) {
if let Ok(signature) = serde_json::from_slice::<Signature>(signature) {
let plugin_decl = PluginDeclaration::new(filename, signature);
working_set.add_plugin_decl(Box::new(plugin_decl));
None
} else {
Some(ParseError::PluginError(
"unable to deserialize signature".into(),
))
}
} else {
Some(ParseError::NonUtf8(spans[1]))
}
}
_ => {
let span = spans[2..].iter().fold(spans[2], |acc, next| Span {
let span = spans[3..].iter().fold(spans[3], |acc, next| Span {
start: acc.start,
end: next.end,
});