From 88bbe4abaaf75cc00470eef8c01412bee68a9d58 Mon Sep 17 00:00:00 2001
From: Matthias Meschede <MMesch@users.noreply.github.com>
Date: Wed, 5 Mar 2025 17:03:35 +0100
Subject: [PATCH] Add Xor to polars plugin nu_expressions (#15249)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

solution for #15242 ,  based on PR #15248 .

Allows doing this:

```
~/Projects/nushell> [[a, b]; [1., 2.], [3.,3.], [4., 6.]] | polars into-df | polars filter (((polars col a) < 2) xor ((polars col b) > 5))
╭───┬──────┬──────╮
│ # │  a   │  b   │
├───┼──────┼──────┤
│ 0 │ 1.00 │ 2.00 │
│ 1 │ 4.00 │ 6.00 │
╰───┴──────┴──────╯
```
---
 .../values/nu_expression/custom_value.rs      | 22 ++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/crates/nu_plugin_polars/src/dataframe/values/nu_expression/custom_value.rs b/crates/nu_plugin_polars/src/dataframe/values/nu_expression/custom_value.rs
index e0da3012c5..b5a918f287 100644
--- a/crates/nu_plugin_polars/src/dataframe/values/nu_expression/custom_value.rs
+++ b/crates/nu_plugin_polars/src/dataframe/values/nu_expression/custom_value.rs
@@ -7,7 +7,7 @@ use std::ops::{Add, Div, Mul, Rem, Sub};
 use super::NuExpression;
 use nu_plugin::EngineInterface;
 use nu_protocol::{
-    ast::{Comparison, Math, Operator},
+    ast::{Boolean, Comparison, Math, Operator},
     CustomValue, ShellError, Span, Type, Value,
 };
 use polars::prelude::Expr;
@@ -133,6 +133,21 @@ fn with_operator(
             .apply_with_expr(right.clone(), Expr::lt_eq)
             .cache(plugin, engine, lhs_span)?
             .into_value(lhs_span)),
+        Operator::Boolean(Boolean::And) => Ok(left
+            .clone()
+            .apply_with_expr(right.clone(), Expr::logical_and)
+            .cache(plugin, engine, lhs_span)?
+            .into_value(lhs_span)),
+        Operator::Boolean(Boolean::Or) => Ok(left
+            .clone()
+            .apply_with_expr(right.clone(), Expr::logical_or)
+            .cache(plugin, engine, lhs_span)?
+            .into_value(lhs_span)),
+        Operator::Boolean(Boolean::Xor) => Ok(left
+            .clone()
+            .apply_with_expr(right.clone(), logical_xor)
+            .cache(plugin, engine, lhs_span)?
+            .into_value(lhs_span)),
         op => Err(ShellError::OperatorUnsupportedType {
             op,
             unsupported: Type::Custom(TYPE_NAME.into()),
@@ -143,6 +158,11 @@ fn with_operator(
     }
 }
 
+pub fn logical_xor(a: Expr, b: Expr) -> Expr {
+    (a.clone().or(b.clone())) // A OR B
+        .and((a.and(b)).not()) // AND with NOT (A AND B)
+}
+
 fn apply_arithmetic<F>(
     plugin: &PolarsPlugin,
     engine: &EngineInterface,