mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 14:40:06 +02:00
Change other instances of $nothing
to null
(#7569)
# Description Purely for consistency, various remaining instances of `$nothing` (almost all of which were in test code) have been changed to `null`. Now, the only place that refers to `$nothing` is the parser code which implements it. # User-Facing Changes The default config.nu now uses `null` in certain places where it used `$nothing`. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -532,7 +532,7 @@ fn proper_shadow_load_env_aliases() {
|
||||
assert_eq!(actual.out, "truefalsetrue");
|
||||
}
|
||||
|
||||
//FIXME: jt: load-env can not currently hide variables because $nothing no longer hides
|
||||
//FIXME: jt: load-env can not currently hide variables because null no longer hides
|
||||
#[ignore]
|
||||
#[test]
|
||||
fn load_env_can_hide_var_envs() {
|
||||
@ -541,7 +541,7 @@ fn load_env_can_hide_var_envs() {
|
||||
r#"
|
||||
let-env DEBUG = "1"
|
||||
echo $env.DEBUG
|
||||
load-env [[name, value]; [DEBUG $nothing]]
|
||||
load-env [[name, value]; [DEBUG null]]
|
||||
echo $env.DEBUG
|
||||
"#
|
||||
);
|
||||
@ -550,7 +550,7 @@ fn load_env_can_hide_var_envs() {
|
||||
assert!(actual.err.contains("Unknown column"));
|
||||
}
|
||||
|
||||
//FIXME: jt: load-env can not currently hide variables because $nothing no longer hides
|
||||
//FIXME: jt: load-env can not currently hide variables because null no longer hides
|
||||
#[ignore]
|
||||
#[test]
|
||||
fn load_env_can_hide_var_envs_in_parent_scope() {
|
||||
@ -560,7 +560,7 @@ fn load_env_can_hide_var_envs_in_parent_scope() {
|
||||
let-env DEBUG = "1"
|
||||
echo $env.DEBUG
|
||||
do {
|
||||
load-env [[name, value]; [DEBUG $nothing]]
|
||||
load-env [[name, value]; [DEBUG null]]
|
||||
echo $env.DEBUG
|
||||
}
|
||||
echo $env.DEBUG
|
||||
@ -1176,7 +1176,7 @@ fn nothing_string_1() {
|
||||
let actual = nu!(
|
||||
cwd: ".", pipeline(
|
||||
r#"
|
||||
$nothing == "foo"
|
||||
null == "foo"
|
||||
"#)
|
||||
);
|
||||
|
||||
|
Reference in New Issue
Block a user