mirror of
https://github.com/nushell/nushell.git
synced 2024-12-22 07:02:19 +01:00
Update PR template (#12838)
# Description Updates the command listed in the PR template to test the standard library, following from #11151.
This commit is contained in:
parent
c4dca5fe03
commit
905ec88091
2
.github/pull_request_template.md
vendored
2
.github/pull_request_template.md
vendored
@ -26,7 +26,7 @@ Make sure you've run and fixed any issues with these commands:
|
||||
- `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes)
|
||||
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style
|
||||
- `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
|
||||
- `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library
|
||||
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library
|
||||
|
||||
> **Note**
|
||||
> from `nushell` you can also use the `toolkit` as follows
|
||||
|
@ -287,7 +287,7 @@ export def run-tests [
|
||||
--list, # list the selected tests without running them.
|
||||
--threads: int@"nu-complete threads", # Amount of threads to use for parallel execution. Default: All threads are utilized
|
||||
] {
|
||||
let available_threads = (sys | get cpu | length)
|
||||
let available_threads = (sys cpu | length)
|
||||
|
||||
# Can't use pattern matching here due to https://github.com/nushell/nushell/issues/9198
|
||||
let threads = (if $threads == null {
|
||||
|
Loading…
Reference in New Issue
Block a user