extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 02:14:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Shrink the size of Expr (#12610)

Browse Source 
# Description
Continuing from #12568, this PR further reduces the size of `Expr` from
64 to 40 bytes. It also reduces `Expression` from 128 to 96 bytes and
`Type` from 32 to 24 bytes.

This was accomplished by:
- for `Expr` with multiple fields (e.g., `Expr::Thing(A, B, C)`),
merging the fields into new AST struct types and then boxing this struct
(e.g. `Expr::Thing(Box<ABC>)`).
- replacing `Vec<T>` with `Box<[T]>` in multiple places. `Expr`s and
`Expression`s should rarely be mutated, if at all, so this optimization
makes sense.

By reducing the size of these types, I didn't notice a large performance
improvement (at least compared to #12568). But this PR does reduce the
memory usage of nushell. My config is somewhat light so I only noticed a
difference of 1.4MiB (38.9MiB vs 37.5MiB).

---------

Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
This commit is contained in:
Ian Manske
2024-04-24 15:46:35 +00:00
committed by GitHub
parent c52884b3c8
commit 9996e4a1f8
195 changed files with 688 additions and 601 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/nu-command/src/math/avg.rs
View File

@ -23,8 +23,8 @@ impl Command for SubCommand {
(Type::List(Box::new(Type::Number)), Type::Number),
(Type::Number, Type::Number),
(Type::Range, Type::Number),
(Type::Table(vec![]), Type::Record(vec![])),
(Type::Record(vec![]), Type::Record(vec![])),
(Type::table(), Type::record()),
(Type::record(), Type::record()),
])
.allow_variants_without_examples(true)
.category(Category::Math)

4
crates/nu-command/src/math/max.rs
View File

@ -20,8 +20,8 @@ impl Command for SubCommand {
(Type::List(Box::new(Type::Filesize)), Type::Filesize),
(Type::List(Box::new(Type::Any)), Type::Any),
(Type::Range, Type::Number),
(Type::Table(vec![]), Type::Record(vec![])),
(Type::Record(vec![]), Type::Record(vec![])),
(Type::table(), Type::record()),
(Type::record(), Type::record()),
])
.allow_variants_without_examples(true)
.category(Category::Math)

4
crates/nu-command/src/math/median.rs
View File

@ -17,8 +17,8 @@ impl Command for SubCommand {
(Type::List(Box::new(Type::Duration)), Type::Duration),
(Type::List(Box::new(Type::Filesize)), Type::Filesize),
(Type::Range, Type::Number),
(Type::Table(vec![]), Type::Record(vec![])),
(Type::Record(vec![]), Type::Record(vec![])),
(Type::table(), Type::record()),
(Type::record(), Type::record()),
])
.allow_variants_without_examples(true)
.category(Category::Math)

4
crates/nu-command/src/math/min.rs
View File

@ -20,8 +20,8 @@ impl Command for SubCommand {
(Type::List(Box::new(Type::Filesize)), Type::Filesize),
(Type::List(Box::new(Type::Any)), Type::Any),
(Type::Range, Type::Number),
(Type::Table(vec![]), Type::Record(vec![])),
(Type::Record(vec![]), Type::Record(vec![])),
(Type::table(), Type::record()),
(Type::record(), Type::record()),
])
.allow_variants_without_examples(true)
.category(Category::Math)

2
crates/nu-command/src/math/mode.rs
View File

@ -48,7 +48,7 @@ impl Command for SubCommand {
Type::List(Box::new(Type::Filesize)),
Type::List(Box::new(Type::Filesize)),
),
(Type::Table(vec![]), Type::Record(vec![])),
(Type::table(), Type::record()),
])
.allow_variants_without_examples(true)
.category(Category::Math)

4
crates/nu-command/src/math/product.rs
View File

@ -17,8 +17,8 @@ impl Command for SubCommand {
.input_output_types(vec![
(Type::List(Box::new(Type::Number)), Type::Number),
(Type::Range, Type::Number),
(Type::Table(vec![]), Type::Record(vec![])),
(Type::Record(vec![]), Type::Record(vec![])),
(Type::table(), Type::record()),
(Type::record(), Type::record()),
])
.allow_variants_without_examples(true)
.category(Category::Math)

4
crates/nu-command/src/math/stddev.rs
View File

@ -14,8 +14,8 @@ impl Command for SubCommand {
Signature::build("math stddev")
.input_output_types(vec![
(Type::List(Box::new(Type::Number)), Type::Number),
(Type::Table(vec![]), Type::Record(vec![])),
(Type::Record(vec![]), Type::Record(vec![])),
(Type::table(), Type::record()),
(Type::record(), Type::record()),
])
.switch(
"sample",

4
crates/nu-command/src/math/sum.rs
View File

@ -19,8 +19,8 @@ impl Command for SubCommand {
(Type::List(Box::new(Type::Duration)), Type::Duration),
(Type::List(Box::new(Type::Filesize)), Type::Filesize),
(Type::Range, Type::Number),
(Type::Table(vec![]), Type::Record(vec![])),
(Type::Record(vec![]), Type::Record(vec![])),
(Type::table(), Type::record()),
(Type::record(), Type::record()),
])
.allow_variants_without_examples(true)
.category(Category::Math)

4
crates/nu-command/src/math/variance.rs
View File

@ -13,8 +13,8 @@ impl Command for SubCommand {
Signature::build("math variance")
.input_output_types(vec![
(Type::List(Box::new(Type::Number)), Type::Number),
(Type::Table(vec![]), Type::Record(vec![])),
(Type::Record(vec![]), Type::Record(vec![])),
(Type::table(), Type::record()),
(Type::record(), Type::record()),
])
.switch(
"sample",