extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-30 22:50:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Box ImportPattern in Expr (#12568)

Browse Source 
# Description
Adds a `Box` around the `ImportPattern` in `Expr` which decreases the
size of `Expr` from 152 to 64 bytes (and `Expression` from 216 to 128
bytes). This seems to speed up parsing a little bit according to the
benchmarks (main is top, PR is bottom):
```
benchmarks                       fastest       │ slowest       │ median        │ mean          │ samples │ iters
benchmarks                       fastest       │ slowest       │ median        │ mean          │ samples │ iters
├─ parser_benchmarks                           │               │               │               │         │
├─ parser_benchmarks                           │               │               │               │         │
│  ├─ parse_default_config_file  2.287 ms      │ 4.532 ms      │ 2.311 ms      │ 2.437 ms      │ 100     │ 100
│  ├─ parse_default_config_file  2.255 ms      │ 2.781 ms      │ 2.281 ms      │ 2.312 ms      │ 100     │ 100
│  ╰─ parse_default_env_file     421.8 µs      │ 824.6 µs      │ 494.3 µs      │ 527.5 µs      │ 100     │ 100
│  ╰─ parse_default_env_file     402 µs        │ 486.6 µs      │ 414.8 µs      │ 416.2 µs      │ 100     │ 100

```
This commit is contained in:
Ian Manske
2024-04-18 15:57:01 +00:00
committed by GitHub
parent b088f395dc
commit 9a265847e2
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/nu-parser/src/parser.rs
View File

@ -2782,7 +2782,7 @@ pub fn parse_import_pattern(working_set: &mut StateWorkingSet, spans: &[Span]) -
prev_span,
));
return Expression {
expr: Expr::ImportPattern(import_pattern),
expr: Expr::ImportPattern(Box::new(import_pattern)),
span: prev_span,
ty: Type::List(Box::new(Type::String)),
custom_completion: None,
@ -2828,7 +2828,7 @@ pub fn parse_import_pattern(working_set: &mut StateWorkingSet, spans: &[Span]) -
} else {
working_set.error(ParseError::ExportNotFound(result.span));
return Expression {
expr: Expr::ImportPattern(import_pattern),
expr: Expr::ImportPattern(Box::new(import_pattern)),
span: span(spans),
ty: Type::List(Box::new(Type::String)),
custom_completion: None,
@ -2848,7 +2848,7 @@ pub fn parse_import_pattern(working_set: &mut StateWorkingSet, spans: &[Span]) -
}
Expression {
expr: Expr::ImportPattern(import_pattern),
expr: Expr::ImportPattern(Box::new(import_pattern)),
span: span(&spans[1..]),
ty: Type::List(Box::new(Type::String)),
custom_completion: None,