From af2439e8800f8e651ed05313fda984a6ddddb484 Mon Sep 17 00:00:00 2001
From: Issac Trotts <ijt@sourcegraph.com>
Date: Sat, 24 Aug 2019 14:55:42 -0700
Subject: [PATCH 1/3] add test

---
 tests/filters_test.rs | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/filters_test.rs b/tests/filters_test.rs
index 8b0e40bef3..d398b4f0a6 100644
--- a/tests/filters_test.rs
+++ b/tests/filters_test.rs
@@ -89,3 +89,14 @@ fn can_filter_by_unit_size_comparison() {
 
     assert_eq!(output, "caco3_plastics.csv");
 }
+
+#[test]
+fn can_get_last() {
+    nu!(
+        output,
+        cwd("tests/fixtures/formats"),
+        "ls | last 1 | get name | trim | echo $it"
+    );
+
+    assert_eq!(output, "utf16.ini");
+}
\ No newline at end of file

From 108f66941b70bb0b304e4b5ef9f43a0c7fbededb Mon Sep 17 00:00:00 2001
From: Issac Trotts <ijt@sourcegraph.com>
Date: Sat, 24 Aug 2019 11:32:48 -0700
Subject: [PATCH 2/3] add last command

---
 src/cli.rs            |  2 ++
 src/commands.rs       |  2 ++
 src/commands/last.rs  | 59 +++++++++++++++++++++++++++++++++++++++++++
 tests/filters_test.rs |  2 +-
 4 files changed, 64 insertions(+), 1 deletion(-)
 create mode 100644 src/commands/last.rs

diff --git a/src/cli.rs b/src/cli.rs
index 28fef95560..a04a6211b9 100644
--- a/src/cli.rs
+++ b/src/cli.rs
@@ -168,6 +168,8 @@ pub async fn cli() -> Result<(), Box<dyn Error>> {
             whole_stream_command(SortBy),
             whole_stream_command(Tags),
             whole_stream_command(First),
+            whole_stream_command(Last),
+            whole_stream_command(FromArray),
             whole_stream_command(FromArray),
             whole_stream_command(FromCSV),
             whole_stream_command(FromINI),
diff --git a/src/commands.rs b/src/commands.rs
index 19995ab7a5..3728474f22 100644
--- a/src/commands.rs
+++ b/src/commands.rs
@@ -22,6 +22,7 @@ crate mod from_toml;
 crate mod from_xml;
 crate mod from_yaml;
 crate mod get;
+crate mod last;
 crate mod lines;
 crate mod ls;
 crate mod mkdir;
@@ -76,6 +77,7 @@ crate use from_toml::FromTOML;
 crate use from_xml::FromXML;
 crate use from_yaml::FromYAML;
 crate use get::Get;
+crate use last::Last;
 crate use lines::Lines;
 crate use ls::LS;
 crate use mkdir::Mkdir;
diff --git a/src/commands/last.rs b/src/commands/last.rs
new file mode 100644
index 0000000000..18a2da96a5
--- /dev/null
+++ b/src/commands/last.rs
@@ -0,0 +1,59 @@
+use crate::commands::WholeStreamCommand;
+use crate::errors::ShellError;
+use crate::parser::CommandRegistry;
+use crate::prelude::*;
+
+pub struct Last;
+
+impl WholeStreamCommand for Last {
+    fn run(
+        &self,
+        args: CommandArgs,
+        registry: &CommandRegistry,
+    ) -> Result<OutputStream, ShellError> {
+        last(args, registry)
+    }
+
+    fn name(&self) -> &str {
+        "last"
+    }
+
+    fn signature(&self) -> Signature {
+        Signature::build("last").required("amount", SyntaxType::Literal)
+    }
+}
+
+fn last(args: CommandArgs, registry: &CommandRegistry) -> Result<OutputStream, ShellError> {
+    let args = args.evaluate_once(registry)?;
+
+    let amount = args.expect_nth(0)?.as_i64();
+
+    let amount = match amount {
+        Ok(o) => o,
+        Err(_) => {
+            return Err(ShellError::labeled_error(
+                "Value is not a number",
+                "expected integer",
+                args.expect_nth(0)?.span(),
+            ))
+        }
+    };
+
+    if amount <= 0 {
+        return Err(ShellError::labeled_error(
+            "Value is too low",
+            "expected a positive integer",
+            args.expect_nth(0)?.span(),
+        ))
+    }
+
+    let stream = async_stream_block! {
+        let v: Vec<_> = args.input.into_vec().await;
+        let k = v.len() - (amount as usize);
+        for x in v[k..].iter() {
+            let y: Tagged<Value> = x.clone();
+            yield ReturnSuccess::value(y)
+        }
+    };
+    Ok(stream.to_output_stream())
+}
diff --git a/tests/filters_test.rs b/tests/filters_test.rs
index d398b4f0a6..08aabde344 100644
--- a/tests/filters_test.rs
+++ b/tests/filters_test.rs
@@ -99,4 +99,4 @@ fn can_get_last() {
     );
 
     assert_eq!(output, "utf16.ini");
-}
\ No newline at end of file
+}

From 45d514a4cbd15f51e73aab10c95f77ecc5499b10 Mon Sep 17 00:00:00 2001
From: Issac Trotts <ijt@sourcegraph.com>
Date: Sat, 24 Aug 2019 17:21:09 -0700
Subject: [PATCH 3/3] sort to get test to pass on linux

---
 tests/filters_test.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/filters_test.rs b/tests/filters_test.rs
index 08aabde344..5253dea33d 100644
--- a/tests/filters_test.rs
+++ b/tests/filters_test.rs
@@ -95,7 +95,7 @@ fn can_get_last() {
     nu!(
         output,
         cwd("tests/fixtures/formats"),
-        "ls | last 1 | get name | trim | echo $it"
+        "ls | sort-by name | last 1 | get name | trim | echo $it"
     );
 
     assert_eq!(output, "utf16.ini");