expand paths and split PATH in std path add (#10710)

related to
-
https://discord.com/channels/601130461678272522/614593951969574961/1162406310155923626

# Description
this PR
- does a bit of minor refactoring
- makes sure the input paths get expanded
- makes sure the input PATH gets split on ":"
- adds a test
- fixes the other tests

# User-Facing Changes
should give a better overall experience with `std path add`

# Tests + Formatting
adds a new test case to the `path_add` test and fixes the others.

# After Submitting
This commit is contained in:
Antoine Stevan
2023-10-25 16:43:27 +02:00
committed by GitHub
parent f3656f7822
commit a11e41332c
2 changed files with 22 additions and 16 deletions

View File

@ -12,19 +12,19 @@ def path_add [] {
assert equal (get_path) []
std path add "/foo/"
assert equal (get_path) ["/foo/"]
assert equal (get_path) (["/foo/"] | path expand)
std path add "/bar/" "/baz/"
assert equal (get_path) ["/bar/", "/baz/", "/foo/"]
assert equal (get_path) (["/bar/", "/baz/", "/foo/"] | path expand)
load-env {$path_name: []}
std path add "foo"
std path add "bar" "baz" --append
assert equal (get_path) ["foo", "bar", "baz"]
assert equal (get_path) (["foo", "bar", "baz"] | path expand)
assert equal (std path add "fooooo" --ret) ["fooooo", "foo", "bar", "baz"]
assert equal (get_path) ["fooooo", "foo", "bar", "baz"]
assert equal (std path add "fooooo" --ret) (["fooooo", "foo", "bar", "baz"] | path expand)
assert equal (get_path) (["fooooo", "foo", "bar", "baz"] | path expand)
load-env {$path_name: []}
@ -36,7 +36,11 @@ def path_add [] {
}
std path add $target_paths
assert equal (get_path) [($target_paths | get $nu.os-info.name)]
assert equal (get_path) ([($target_paths | get $nu.os-info.name)] | path expand)
load-env {$path_name: [$"/foo(char esep)/bar"]}
std path add "~/foo"
assert equal (get_path) (["~/foo", "/foo", "/bar"] | path expand)
}
}