extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 20:47:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(nu-command/parse)!: Return null for unmatched capture groups, rather than empty string (#16094)

Browse Source 
Co-authored-by: Bahex <17417311+Bahex@users.noreply.github.com>
This commit is contained in:
Bahex
2025-07-02 20:32:52 +03:00
committed by GitHub
parent 25a5e8d8e8
commit a340e965e8
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/nu-command/src/strings/parse.rs
View File

@ -78,12 +78,12 @@ impl Command for Parse {
example: "\"foo! bar.\" | parse --regex '(\\w+)(?=\\.)|(\\w+)(?=!)'", example: "\"foo! bar.\" | parse --regex '(\\w+)(?=\\.)|(\\w+)(?=!)'",
result: Some(Value::test_list(vec![ result: Some(Value::test_list(vec![
Value::test_record(record! { Value::test_record(record! {
"capture0" => Value::test_string(""), "capture0" => Value::test_nothing(),
"capture1" => Value::test_string("foo"), "capture1" => Value::test_string("foo"),
}), }),
Value::test_record(record! { Value::test_record(record! {
"capture0" => Value::test_string("bar"), "capture0" => Value::test_string("bar"),
"capture1" => Value::test_string(""), "capture1" => Value::test_nothing(),
}), }),
])), ])),
}, },
@ -398,8 +398,10 @@ fn captures_to_value(
.iter() .iter()
.zip(captures.iter().skip(1)) .zip(captures.iter().skip(1))
.map(|(column, match_)| { .map(|(column, match_)| {
let match_str = match_.map(|m| m.as_str()).unwrap_or(""); let match_value = match_
(column.clone(), Value::string(match_str, span)) .map(|m| Value::string(m.as_str(), span))
.unwrap_or(Value::nothing(span));
(column.clone(), match_value)
}) })
.collect(); .collect();