Make Semicolon stop on error (#6079)

* introduce external command runs to failed error, and implement semicolon relative logic

* ignore test due to semicolon works

* not raise ShellError for external commands

* update comment

* add relative test in for windows

* fix type-o

Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>

crates/nu-command/src/core_commands/if_.rs

@@ -92,6 +92,7 @@ impl Command for If {
                                 call.redirect_stdout,
                                 call.redirect_stderr,
                             )
+                            .map(|res| res.0)
                         }
                     } else {
                         eval_expression_with_input(
@@ -102,6 +103,7 @@ impl Command for If {
                             call.redirect_stdout,
                             call.redirect_stderr,
                         )
+                        .map(|res| res.0)
                     }
                 } else {
                     Ok(PipelineData::new(call.head))

crates/nu-command/src/core_commands/let_.rs

@@ -61,7 +61,8 @@ impl Command for Let {
             input,
             call.redirect_stdout,
             call.redirect_stderr,
-        )?;
+        )?
+        .0;
 
         //println!("Adding: {:?} to {}", rhs, var_id);
 

crates/nu-command/src/env/let_env.rs

@@ -43,6 +43,7 @@ impl Command for LetEnv {
 
         let rhs =
             eval_expression_with_input(engine_state, stack, keyword_expr, input, false, true)?
+                .0
                 .into_value(call.head);
 
         if env_var == "PWD" {

crates/nu-command/tests/commands/run_external.rs

@@ -123,6 +123,21 @@ fn double_quote_does_not_expand_path_glob() {
     })
 }
 
+#[cfg(not(windows))]
+#[test]
+fn failed_command_with_semicolon_will_not_execute_following_cmds() {
+    Playground::setup("external failed command with semicolon", |dirs, _| {
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ^ls *.abc; echo done
+            "#
+        ));
+
+        assert!(!actual.out.contains("done"));
+    })
+}
+
 #[cfg(windows)]
 #[test]
 fn explicit_glob_windows() {
@@ -166,6 +181,21 @@ fn bare_word_expand_path_glob_windows() {
     })
 }
 
+#[cfg(windows)]
+#[test]
+fn failed_command_with_semicolon_will_not_execute_following_cmds_windows() {
+    Playground::setup("external failed command with semicolon", |dirs, _| {
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ^cargo asdf; echo done
+            "#
+        ));
+
+        assert!(!actual.out.contains("done"));
+    })
+}
+
 #[cfg(windows)]
 #[test]
 // This test case might fail based on the running shell on Windows - CMD vs PowerShell, the reason is