mirror of
https://github.com/nushell/nushell.git
synced 2025-08-13 08:17:44 +02:00
Box ShellError
in Value::Error
(#8375)
# Description Our `ShellError` at the moment has a `std::mem::size_of<ShellError>` of 136 bytes (on AMD64). As a result `Value` directly storing the struct also required 136 bytes (thanks to alignment requirements). This change stores the `Value::Error` `ShellError` on the heap. Pro: - Value now needs just 80 bytes - Should be 1 cacheline less (still at least 2 cachelines) Con: - More small heap allocations when dealing with `Value::Error` - More heap fragmentation - Potential for additional required memcopies # Further code changes Includes a small refactor of `try` due to a type mismatch in its large match. # User-Facing Changes None for regular users. Plugin authors may have to update their matches on `Value` if they use `nu-protocol` Needs benchmarking to see if there is a benefit in real world workloads. **Update** small improvements in runtime for workloads with high volume of values. Significant reduction in maximum resident set size, when many values are held in memory. # Tests + Formatting
This commit is contained in:
committed by
GitHub
parent
c26d91fb61
commit
a52386e837
@ -79,7 +79,7 @@ impl HashableValue {
|
||||
Value::Binary { val, span } => Ok(HashableValue::Binary { val, span }),
|
||||
|
||||
// Explicitly propagate errors instead of dropping them.
|
||||
Value::Error { error } => Err(error),
|
||||
Value::Error { error } => Err(*error),
|
||||
_ => Err(ShellError::UnsupportedInput(
|
||||
"input value is not hashable".into(),
|
||||
format!("input type: {:?}", value.get_type()),
|
||||
@ -236,7 +236,7 @@ mod test {
|
||||
},
|
||||
Value::Nothing { span },
|
||||
Value::Error {
|
||||
error: ShellError::DidYouMean("what?".to_string(), span),
|
||||
error: Box::new(ShellError::DidYouMean("what?".to_string(), span)),
|
||||
},
|
||||
Value::CellPath {
|
||||
val: CellPath {
|
||||
|
@ -160,7 +160,7 @@ fn run_histogram(
|
||||
for v in values {
|
||||
match v {
|
||||
// Propagate existing errors.
|
||||
Value::Error { error } => return Err(error),
|
||||
Value::Error { error } => return Err(*error),
|
||||
_ => {
|
||||
let t = v.get_type();
|
||||
let span = v.expect_span();
|
||||
@ -198,7 +198,7 @@ fn run_histogram(
|
||||
}
|
||||
}
|
||||
// Propagate existing errors.
|
||||
Value::Error { error } => return Err(error),
|
||||
Value::Error { error } => return Err(*error),
|
||||
_ => continue,
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user