update default_config with new defaults (#11856)

# Description

Update a few defaults.
1. use_ls_colors_completeions defaults to true.
2. make ide_menu only offer 10 completions at a time with
`max_completion_height = 10` instead of taking the entire screen.

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
This commit is contained in:
Darren Schroeder 2024-02-14 13:01:27 -06:00 committed by GitHub
parent b0600449e5
commit a603b067e5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions

View File

@ -402,7 +402,7 @@ pub(crate) fn add_ide_menu(
let max_completion_height = max_completion_height.as_int()?;
ide_menu.with_max_completion_height(max_completion_height as u16)
}
Err(_) => ide_menu,
Err(_) => ide_menu.with_max_completion_height(10u16),
};
ide_menu = match extract_value("padding", val, span) {
@ -447,7 +447,7 @@ pub(crate) fn add_ide_menu(
});
}
}
Err(_) => ide_menu,
Err(_) => ide_menu.with_default_border(),
};
ide_menu = match extract_value("cursor_offset", val, span) {

View File

@ -130,7 +130,7 @@ impl Default for Config {
enable_external_completion: true,
max_external_completion_results: 100,
external_completer: None,
use_ls_colors_completions: false,
use_ls_colors_completions: true,
filesize_metric: false,
filesize_format: "auto".into(),

View File

@ -212,7 +212,7 @@ $env.config = {
max_results: 100 # setting it lower can improve completion performance at the cost of omitting some options
completer: null # check 'carapace_completer' above as an example
}
use_ls_colors: false # set this to true to enable file/path/directory completions using LS_COLORS
use_ls_colors: true # set this to true to enable file/path/directory completions using LS_COLORS
}
filesize: {
@ -280,7 +280,7 @@ $env.config = {
layout: ide
min_completion_width: 0,
max_completion_width: 50,
# max_completion_height: 10, # will be limited by the available lines in the terminal
max_completion_height: 10, # will be limited by the available lines in the terminal
padding: 0,
border: true,
cursor_offset: 0,