mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 22:50:14 +02:00
Restrict closure expression to be something like {|| ...}
(#8290)
# Description As title, closes: #7921 closes: #8273 # User-Facing Changes when define a closure without pipe, nushell will raise error for now: ``` ❯ let x = {ss ss} Error: nu::parser::closure_missing_pipe × Missing || inside closure ╭─[entry #2:1:1] 1 │ let x = {ss ss} · ───┬─── · ╰── Parsing as a closure, but || is missing ╰──── help: Try add || to the beginning of closure ``` `any`, `each`, `all`, `where` command accepts closure, it forces user input closure like `{||`, or parse error will returned. ``` ❯ {major:2, minor:1, patch:4} | values | each { into string } Error: nu::parser::closure_missing_pipe × Missing || inside closure ╭─[entry #4:1:1] 1 │ {major:2, minor:1, patch:4} | values | each { into string } · ───────┬─────── · ╰── Parsing as a closure, but || is missing ╰──── help: Try add || to the beginning of closure ``` `with-env`, `do`, `def`, `try` are special, they still remain the same, although it says that it accepts a closure, but they don't need to be written like `{||`, it's more likely a block but can capture variable outside of scope: ``` ❯ def test [input] { echo [0 1 2] | do { do { echo $input } } }; test aaa aaa ``` Just realize that It's a big breaking change, we need to update config and scripts... # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -111,7 +111,7 @@ fn test_time_closure() {
|
||||
use nu_test_support::{nu, nu_repl_code, playground::Playground};
|
||||
Playground::setup("test_time_closure", |dirs, _| {
|
||||
let inp = [
|
||||
r#"[2 3 4] | timeit { to nuon | save foo.txt }"#,
|
||||
r#"[2 3 4] | timeit {|_| to nuon | save foo.txt }"#,
|
||||
"open foo.txt",
|
||||
];
|
||||
let actual_repl = nu!(cwd: dirs.test(), nu_repl_code(&inp));
|
||||
|
@ -45,7 +45,7 @@ impl Command for All {
|
||||
},
|
||||
Example {
|
||||
description: "Check that each item is a string",
|
||||
example: "[foo bar 2 baz] | all { ($in | describe) == 'string' }",
|
||||
example: "[foo bar 2 baz] | all {|| ($in | describe) == 'string' }",
|
||||
result: Some(Value::test_bool(false)),
|
||||
},
|
||||
Example {
|
||||
|
@ -45,7 +45,7 @@ impl Command for Any {
|
||||
},
|
||||
Example {
|
||||
description: "Check that any item is a string",
|
||||
example: "[1 2 3 4] | any { ($in | describe) == 'string' }",
|
||||
example: "[1 2 3 4] | any {|| ($in | describe) == 'string' }",
|
||||
result: Some(Value::test_bool(false)),
|
||||
},
|
||||
Example {
|
||||
|
@ -74,7 +74,7 @@ with 'transpose' first."#
|
||||
}),
|
||||
},
|
||||
Example {
|
||||
example: "{major:2, minor:1, patch:4} | values | each { into string }",
|
||||
example: "{major:2, minor:1, patch:4} | values | each {|| into string }",
|
||||
description: "Produce a list of values in the record, converted to string",
|
||||
result: Some(Value::List {
|
||||
vals: vec![
|
||||
|
Reference in New Issue
Block a user