Convert Shellerror::GenericError to named fields (#11230)

# Description

Replace `.to_string()` used in `GenericError` with `.into()` as
`.into()` seems more popular

Replace `Vec::new()` used in `GenericError` with `vec![]` as `vec![]`
seems more popular

(There are so, so many)
This commit is contained in:
Eric Hodel
2023-12-06 15:40:03 -08:00
committed by GitHub
parent b03f1efac4
commit a95a4505ef
160 changed files with 2975 additions and 3228 deletions

View File

@ -153,13 +153,13 @@ fn convert_with_precision(val: &str, precision: usize) -> Result<String, ShellEr
let val_float = match val.trim().parse::<f64>() {
Ok(f) => f,
Err(e) => {
return Err(ShellError::GenericError(
format!("error converting string [{}] to f64", &val),
"".to_string(),
None,
Some(e.to_string()),
Vec::new(),
));
return Err(ShellError::GenericError {
error: format!("error converting string [{}] to f64", &val),
msg: "".into(),
span: None,
help: Some(e.to_string()),
inner: vec![],
});
}
};
Ok(format!("{val_float:.precision$}"))