From a96836facb8282e562aad8a380478776cfe22c8f Mon Sep 17 00:00:00 2001 From: Jan Koprowski Date: Thu, 19 Sep 2019 17:57:36 +0200 Subject: [PATCH] Use tags instead container id and add all binaries to debian/install --- debian/install | 9 +++++++++ docker/packaging/README.md | 35 ++++++++++++++++++++++++++++++----- 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/debian/install b/debian/install index eca0e05134..75cf2844d9 100644 --- a/debian/install +++ b/debian/install @@ -1 +1,10 @@ target/release/nu usr/bin +target/release/nu_plugin_binaryview usr/bin +target/release/nu_plugin_edit usr/bin +target/release/nu_plugin_inc usr/bin +target/release/nu_plugin_skip usr/bin +target/release/nu_plugin_str usr/bin +target/release/nu_plugin_sum usr/bin +target/release/nu_plugin_sys usr/bin +target/release/nu_plugin_textview usr/bin +target/release/nu_plugin_tree usr/bin diff --git a/docker/packaging/README.md b/docker/packaging/README.md index ecefa0150d..e825c2780f 100644 --- a/docker/packaging/README.md +++ b/docker/packaging/README.md @@ -6,15 +6,40 @@ This directory contains docker images used for creating packages for different d Start with: -`docker build -f docker/packaging/Dockerfile.ubuntu-bionic .` +```bash +$ docker build -f docker/packaging/Dockerfile.ubuntu-bionic -t nushell/package:ubuntu-bionic . +``` -after building the image please run container +after building the image please run container: + +```bash +$ docker run -td --rm --name nushell_package_ubuntu_bionic nushell/package:ubuntu-bionic +``` -`docker run -d --name nushell ` - and copy deb package from inside: -`docker cp nushell:/nu_0.2.0-1_amd64.deb .` +```bash +$ docker cp nushell_package_ubuntu_bionic:/nu_0.2.0-1_amd64.deb . +``` + +or shell inside, and test install: + +```bash +$ docker exec -it nushell_package_ubuntu_bionic bash +$ dpkg -i /nu_0.2.0-1_amd64.deb + +(Reading database ... 25656 files and directories currently installed.) +Preparing to unpack /nu_0.2.0-1_amd64.deb ... +Unpacking nu (0.2.0-1) over (0.2.0-1) ... +Setting up nu (0.2.0-1) ... +``` + +When you are finished, exit and stop the container. It will be removed since we +used `--rm`. + +```bash +$ docker stop nushell_package_ubuntu_bionic +``` ## What should be done