extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 02:45:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

when spawned process during register plugin, pass env to child process (#6261)

Browse Source 
* when spawned process during register plugin, pass env to child process

* tweak comment

* tweak comment

* remove trailing whitespace

Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
This commit is contained in:
WindSoilder
2022-08-08 20:26:49 +08:00
committed by GitHub
parent 2f0cb044a5
commit aaf5684f9c
5 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/nu-parser/src/parse_keywords.rs
View File

@ -2623,7 +2623,8 @@ pub fn parse_register(
expand_aliases_denylist: &[usize],
) -> (Pipeline, Option<ParseError>) {
use nu_plugin::{get_signature, EncodingType, PluginDeclaration};
use nu_protocol::Signature;
use nu_protocol::{engine::Stack, Signature};
let cwd = working_set.get_cwd();
// Checking that the function is used with the correct name
@ -2784,6 +2785,11 @@ pub fn parse_register(
},
};
// We need the current environment variables for `python` based plugins
// Or we'll likely have a problem when a plugin is implemented in a virtual Python environment.
let stack = Stack::new();
let current_envs =
nu_engine::env::env_to_strings(working_set.permanent_state, &stack).unwrap_or_default();
let error = match signature {
Some(signature) => arguments.and_then(|(path, encoding)| {
signature.map(|signature| {
@ -2793,7 +2799,7 @@ pub fn parse_register(
})
}),
None => arguments.and_then(|(path, encoding)| {
get_signature(path.as_path(), &encoding, &shell)
get_signature(path.as_path(), &encoding, &shell, &current_envs)
.map_err(|err| {
ParseError::LabeledError(
"Error getting signatures".into(),