mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 14:40:06 +02:00
Use variable names directly in the format strings (#7906)
# Description Lint: `clippy::uninlined_format_args` More readable in most situations. (May be slightly confusing for modifier format strings https://doc.rust-lang.org/std/fmt/index.html#formatting-parameters) Alternative to #7865 # User-Facing Changes None intended # Tests + Formatting (Ran `cargo +stable clippy --fix --workspace -- -A clippy::all -D clippy::uninlined_format_args` to achieve this. Depends on Rust `1.67`)
This commit is contained in:
committed by
GitHub
parent
6ae497eedc
commit
ab480856a5
@ -174,7 +174,7 @@ fn retrieve_table(mut table: WebTable, columns: &Value, span: Span) -> Value {
|
||||
let mut vals = vec![];
|
||||
for row in &table_with_no_empties {
|
||||
for (counter, cell) in row.iter().enumerate() {
|
||||
cols.push(format!("column{}", counter));
|
||||
cols.push(format!("column{counter}"));
|
||||
vals.push(Value::string(cell.to_string(), span))
|
||||
}
|
||||
}
|
||||
@ -258,7 +258,7 @@ fn execute_selector_query(
|
||||
Value::string(
|
||||
selection
|
||||
.text()
|
||||
.fold("".to_string(), |acc, x| format!("{}{}", acc, x)),
|
||||
.fold("".to_string(), |acc, x| format!("{acc}{x}")),
|
||||
span,
|
||||
)
|
||||
})
|
||||
|
@ -32,7 +32,7 @@ impl WebTable {
|
||||
/// Finds the table in `html` with an id of `id`.
|
||||
pub fn find_by_id(html: &str, id: &str) -> Option<WebTable> {
|
||||
let html = Html::parse_fragment(html);
|
||||
let selector = format!("table#{}", id);
|
||||
let selector = format!("table#{id}");
|
||||
ScraperSelector::parse(&selector)
|
||||
.ok()
|
||||
.as_ref()
|
||||
|
Reference in New Issue
Block a user