extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-07-01 07:00:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use variable names directly in the format strings (#7906)

Browse Source 
# Description

Lint: `clippy::uninlined_format_args`

More readable in most situations.
(May be slightly confusing for modifier format strings
https://doc.rust-lang.org/std/fmt/index.html#formatting-parameters)

Alternative to #7865

# User-Facing Changes

None intended

# Tests + Formatting

(Ran `cargo +stable clippy --fix --workspace -- -A clippy::all -D
clippy::uninlined_format_args` to achieve this. Depends on Rust `1.67`)
This commit is contained in:
Stefan Holderbach
2023-01-30 02:37:54 +01:00
committed by GitHub
parent 6ae497eedc
commit ab480856a5
134 changed files with 386 additions and 431 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/config_files.rs
View File

@ -39,7 +39,7 @@ pub(crate) fn read_config_file(
// Create config directory if it does not exist
if !config_path.exists() {
if let Err(err) = std::fs::create_dir_all(&config_path) {
eprintln!("Failed to create config directory: {}", err);
eprintln!("Failed to create config directory: {err}");
return;
}
}
@ -73,7 +73,7 @@ pub(crate) fn read_config_file(
match answer.to_lowercase().trim() {
"y" | "" => {
if let Ok(mut output) = File::create(&config_path) {
if write!(output, "{}", config_file).is_ok() {
if write!(output, "{config_file}").is_ok() {
let config_type = if is_env_config {
"Environment config"
} else {
@ -93,10 +93,7 @@ pub(crate) fn read_config_file(
return;
}
} else {
eprintln!(
"Unable to create {}, sourcing default file instead",
config_file
);
eprintln!("Unable to create {config_file}, sourcing default file instead");
eval_default_config(engine_state, stack, config_file, is_env_config);
return;
}