mirror of
https://github.com/nushell/nushell.git
synced 2025-07-01 07:00:37 +02:00
make adding newlines with to text
more consistent and opt-out-able (#14158)
# Description This PR tries to make `to text` more consistent with how it adds newlines and also gives you an opt-out --no-newline option.  I wasn't sure how to change the `PipelineData::ByteStream` match arm. I figure something needs to be done there but I'm not sure how to do it. # User-Facing Changes newlines are more consistent. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -415,7 +415,7 @@ fn save_with_custom_converter() {
|
||||
|
||||
nu!(cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
def "to ndjson" []: any -> string { each { to json --raw } | to text } ;
|
||||
def "to ndjson" []: any -> string { each { to json --raw } | to text --no-newline } ;
|
||||
{a: 1, b: 2} | save test.ndjson
|
||||
"#
|
||||
));
|
||||
|
Reference in New Issue
Block a user