mirror of
https://github.com/nushell/nushell.git
synced 2025-08-09 07:16:05 +02:00
Removes unnecessary cwd and pipeline from various tests (#9202)
# Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Cleans up various tests that unnecessarily use the `cwd` argument of `nu!`, and the `pipeline` function for single line commands. Also replaces some unnecessary raw strings with normal strings. Part of #8670. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> None # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> All checks pass # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -4,8 +4,8 @@ use nu_test_support::{nu, pipeline};
|
||||
fn checks_all_rows_are_true() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
echo [ "Andrés", "Andrés", "Andrés" ]
|
||||
| all {|it| $it == "Andrés" }
|
||||
echo [ "Andrés", "Andrés", "Andrés" ]
|
||||
| all {|it| $it == "Andrés" }
|
||||
"#
|
||||
));
|
||||
|
||||
@ -14,14 +14,14 @@ fn checks_all_rows_are_true() {
|
||||
|
||||
#[test]
|
||||
fn checks_all_rows_are_false_with_param() {
|
||||
let actual = nu!(r#" [1, 2, 3, 4] | all { |a| $a >= 5 } "#);
|
||||
let actual = nu!(" [1, 2, 3, 4] | all { |a| $a >= 5 } ");
|
||||
|
||||
assert_eq!(actual.out, "false");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn checks_all_rows_are_true_with_param() {
|
||||
let actual = nu!(r#" [1, 2, 3, 4] | all { |a| $a < 5 } "#);
|
||||
let actual = nu!(" [1, 2, 3, 4] | all { |a| $a < 5 } ");
|
||||
|
||||
assert_eq!(actual.out, "true");
|
||||
}
|
||||
@ -29,16 +29,16 @@ fn checks_all_rows_are_true_with_param() {
|
||||
#[test]
|
||||
fn checks_all_columns_of_a_table_is_true() {
|
||||
let actual = nu!(pipeline(
|
||||
r#"
|
||||
echo [
|
||||
[ first_name, last_name, rusty_at, likes ];
|
||||
[ Andrés, Robalino, '10/11/2013', 1 ]
|
||||
[ JT, Turner, '10/12/2013', 1 ]
|
||||
[ Darren, Schroeder, '10/11/2013', 1 ]
|
||||
[ Yehuda, Katz, '10/11/2013', 1 ]
|
||||
]
|
||||
| all {|x| $x.likes > 0 }
|
||||
"#
|
||||
"
|
||||
echo [
|
||||
[ first_name, last_name, rusty_at, likes ];
|
||||
[ Andrés, Robalino, '10/11/2013', 1 ]
|
||||
[ JT, Turner, '10/12/2013', 1 ]
|
||||
[ Darren, Schroeder, '10/11/2013', 1 ]
|
||||
[ Yehuda, Katz, '10/11/2013', 1 ]
|
||||
]
|
||||
| all {|x| $x.likes > 0 }
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "true");
|
||||
@ -60,35 +60,35 @@ fn checks_if_all_returns_error_with_invalid_command() {
|
||||
|
||||
#[test]
|
||||
fn works_with_1_param_blocks() {
|
||||
let actual = nu!(r#"[1 2 3] | all {|e| print $e | true }"#);
|
||||
let actual = nu!("[1 2 3] | all {|e| print $e | true }");
|
||||
|
||||
assert_eq!(actual.out, "123true");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn works_with_0_param_blocks() {
|
||||
let actual = nu!(r#"[1 2 3] | all {|| print $in | true }"#);
|
||||
let actual = nu!("[1 2 3] | all {|| print $in | true }");
|
||||
|
||||
assert_eq!(actual.out, "123true");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn early_exits_with_1_param_blocks() {
|
||||
let actual = nu!(r#"[1 2 3] | all {|e| print $e | false }"#);
|
||||
let actual = nu!("[1 2 3] | all {|e| print $e | false }");
|
||||
|
||||
assert_eq!(actual.out, "1false");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn early_exits_with_0_param_blocks() {
|
||||
let actual = nu!(r#"[1 2 3] | all {|| print $in | false }"#);
|
||||
let actual = nu!("[1 2 3] | all {|| print $in | false }");
|
||||
|
||||
assert_eq!(actual.out, "1false");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn all_uses_enumerate_index() {
|
||||
let actual = nu!(r#"[7 8 9] | enumerate | all {|el| print $el.index | true }"#);
|
||||
let actual = nu!("[7 8 9] | enumerate | all {|el| print $el.index | true }");
|
||||
|
||||
assert_eq!(actual.out, "012true");
|
||||
}
|
||||
|
Reference in New Issue
Block a user