mirror of
https://github.com/nushell/nushell.git
synced 2025-08-09 07:05:47 +02:00
Removes unnecessary cwd and pipeline from various tests (#9202)
# Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Cleans up various tests that unnecessarily use the `cwd` argument of `nu!`, and the `pipeline` function for single line commands. Also replaces some unnecessary raw strings with normal strings. Part of #8670. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> None # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> All checks pass # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -19,13 +19,13 @@ fn help_commands_length() {
|
||||
|
||||
#[test]
|
||||
fn help_shows_signature() {
|
||||
let actual = nu!(cwd: ".", pipeline("help str distance"));
|
||||
let actual = nu!("help str distance");
|
||||
assert!(actual
|
||||
.out
|
||||
.contains("<string> | str distance <string> -> <int>"));
|
||||
|
||||
// don't show signature for parser keyword
|
||||
let actual = nu!(cwd: ".", pipeline("help alias"));
|
||||
let actual = nu!("help alias");
|
||||
assert!(!actual.out.contains("Signatures"));
|
||||
}
|
||||
|
||||
@ -36,7 +36,7 @@ fn help_aliases() {
|
||||
"alias SPAM = print 'spam'",
|
||||
"help aliases | where name == SPAM | length",
|
||||
];
|
||||
let actual = nu!(cwd: ".", nu_repl_code(code));
|
||||
let actual = nu!(nu_repl_code(code));
|
||||
|
||||
assert_eq!(actual.out, "1");
|
||||
}
|
||||
@ -289,21 +289,21 @@ fn help_usage_extra_usage_command() {
|
||||
"#,
|
||||
)]);
|
||||
|
||||
let actual = nu!(cwd: dirs.test(), pipeline("use spam.nu *; help modules spam"));
|
||||
let actual = nu!(cwd: dirs.test(), "use spam.nu *; help modules spam");
|
||||
assert!(actual.out.contains("module_line1"));
|
||||
assert!(actual.out.contains("module_line2"));
|
||||
|
||||
let actual = nu!(cwd: dirs.test(),
|
||||
pipeline("use spam.nu *; help modules | where name == spam | get 0.usage"));
|
||||
"use spam.nu *; help modules | where name == spam | get 0.usage");
|
||||
assert!(actual.out.contains("module_line1"));
|
||||
assert!(!actual.out.contains("module_line2"));
|
||||
|
||||
let actual = nu!(cwd: dirs.test(), pipeline("use spam.nu *; help commands foo"));
|
||||
let actual = nu!(cwd: dirs.test(), "use spam.nu *; help commands foo");
|
||||
assert!(actual.out.contains("def_line1"));
|
||||
assert!(actual.out.contains("def_line2"));
|
||||
|
||||
let actual = nu!(cwd: dirs.test(),
|
||||
pipeline("use spam.nu *; help commands | where name == foo | get 0.usage"));
|
||||
"use spam.nu *; help commands | where name == foo | get 0.usage");
|
||||
assert!(actual.out.contains("def_line1"));
|
||||
assert!(!actual.out.contains("def_line2"));
|
||||
})
|
||||
@ -356,7 +356,7 @@ fn help_modules_main_1() {
|
||||
"help spam",
|
||||
];
|
||||
|
||||
let actual = nu!(cwd: ".", pipeline(&inp.join("; ")));
|
||||
let actual = nu!(&inp.join("; "));
|
||||
|
||||
assert!(actual.out.contains(" spam"));
|
||||
}
|
||||
|
Reference in New Issue
Block a user