extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 07:55:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(random dice): gracefully handle --sides 0 using NonZeroUsize (#16001)

Browse Source
This commit is contained in:
Kumar Ujjawal
2025-06-23 18:17:50 +05:30
committed by GitHub
parent 680a2fa2aa
commit ae0cf8780d
2 changed files with 51 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
crates/nu-command/src/random/dice.rs
View File

@ -1,6 +1,7 @@
use nu_engine::command_prelude::*;
use nu_protocol::ListStream;
use rand::random_range;
use std::num::NonZeroUsize;
#[derive(Clone)]
pub struct RandomDice;
@ -70,8 +71,16 @@ fn dice(
) -> Result<PipelineData, ShellError> {
let span = call.head;
let dice: usize = call.get_flag(engine_state, stack, "dice")?.unwrap_or(1);
let sides: usize = call.get_flag(engine_state, stack, "sides")?.unwrap_or(6);
let sides: NonZeroUsize = call
.get_flag(engine_state, stack, "sides")?
.unwrap_or_else(|| NonZeroUsize::new(6).expect("default sides must be non-zero"));
let dice: NonZeroUsize = call
.get_flag(engine_state, stack, "dice")?
.unwrap_or_else(|| NonZeroUsize::new(1).expect("default dice count must be non-zero"));
let sides = sides.get();
let dice = dice.get();
let iter = (0..dice).map(move |_| Value::int(random_range(1..sides + 1) as i64, span));