mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 22:50:14 +02:00
skip comments and eols while parsing pipeline (#10149)
This pr - fixes https://github.com/nushell/nushell/issues/10143 - fixes https://github.com/nushell/nushell/issues/5559 # Description Current `lite_parse` does not handle multiple line comments and eols in pipeline. When parsing the following tokens: | `"abcdefg"` | ` \|` | `# foobar` | ` \n` | `split chars` | | ------------- | ------------- |------------- |------------- |------------- | | [Command] | [Pipe] | [Comment] | [Eol] | [Command] | | | | Last Token |Current Token | | `TokenContent::Eol` handler only checks if `last_token` is `Pipe` but it will be broken if there exist any other thing, e.g. extra `[Comment]` in this example. This pr make the following change: - While parsing `[Eol]`, try to find the last non-comment token as `last_token` - Comment is supposed as `[Comment]+` or `([Comment] [Eol])+` - `[Eol]+` is still parsed just like current nu (i.e. generates `nothing`). Notice that this pr is just a quick patch if more comment/eol related issue occures, `lite_parser` may need a rewrite. # User-Facing Changes Now the following pipeline works: ```bash 1 | # comment each { |it| $it + 2 } | # comment math sum ``` Comment will not end the pipeline in interactive mode: ```bash ❯ 1 | # comment (now enter multiple line mode instead of end) ▶▶ # foo ▶▶ 2 ``` # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting None --------- Co-authored-by: Horasal <horsal@horsal.dev>
This commit is contained in:
@ -135,6 +135,41 @@ fn comment_skipping_2() -> TestResult {
|
||||
)
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn comment_skipping_in_pipeline_1() -> TestResult {
|
||||
run_test(
|
||||
r#"[1,2,3] | #comment
|
||||
each { |$it| $it + 2 } | # foo
|
||||
math sum #bar"#,
|
||||
"12",
|
||||
)
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn comment_skipping_in_pipeline_2() -> TestResult {
|
||||
run_test(
|
||||
r#"[1,2,3] #comment
|
||||
| #comment2
|
||||
each { |$it| $it + 2 } #foo
|
||||
| # bar
|
||||
math sum #baz"#,
|
||||
"12",
|
||||
)
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn comment_skipping_in_pipeline_3() -> TestResult {
|
||||
run_test(
|
||||
r#"[1,2,3] | #comment
|
||||
#comment2
|
||||
each { |$it| $it + 2 } #foo
|
||||
| # bar
|
||||
#baz
|
||||
math sum #foobar"#,
|
||||
"12",
|
||||
)
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn bad_var_name() -> TestResult {
|
||||
fail_test(r#"let $"foo bar" = 4"#, "can't contain")
|
||||
|
Reference in New Issue
Block a user