extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 06:25:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make Value::columns return slice instead of cloned Vec (#9927)

Browse Source 
# Description
This PR changes `Value::columns` to return a slice of columns instead of
cloning said columns. If the caller needs an owned copy, they can use
`slice::to_vec` or the like. This eliminates unnecessary Vec clones
(e.g., in `update cells`).

# User-Facing Changes
Breaking change for `nu_protocol` API.
This commit is contained in:
Ian Manske
2023-08-07 19:43:32 +00:00
committed by GitHub
parent d302d63030
commit c070e2d6f7
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/nu-command/src/viewers/griddle.rs
View File

@ -261,7 +261,7 @@ fn convert_to_list(
let mut iter = iter.into_iter().peekable();
if let Some(first) = iter.peek() {
let mut headers = first.columns();
let mut headers = first.columns().to_vec();
if !headers.is_empty() {
headers.insert(0, "#".into());