command open returns error when does not have parameters (#7048) (#7058)

test

Co-authored-by: Ricardo Monteiro <ricardo.monteiro@getmanta.com>

crates/nu-command/src/filesystem/open.rs

@@ -1,16 +1,18 @@
 use crate::filesystem::util::BufferedReader;
-use nu_engine::{eval_block, get_full_help, CallExt};
+use nu_engine::{eval_block, CallExt};
 use nu_protocol::ast::Call;
 use nu_protocol::engine::{Command, EngineState, Stack};
 use nu_protocol::{
-    Category, Example, IntoPipelineData, PipelineData, RawStream, ShellError, Signature, Spanned,
+    Category, Example, PipelineData, RawStream, ShellError, Signature, Spanned, SyntaxShape, Value,
-    SyntaxShape, Value,
 };
 use std::io::BufReader;
 
 #[cfg(feature = "database")]
 use crate::database::SQLiteDatabase;
 
+#[cfg(feature = "database")]
+use nu_protocol::IntoPipelineData;
+
 #[cfg(unix)]
 use std::os::unix::fs::PermissionsExt;
 use std::path::Path;
@@ -67,29 +69,17 @@ impl Command for Open {
             // Collect a filename from the input
             match input {
                 PipelineData::Value(Value::Nothing { .. }, ..) => {
-                    return Ok(Value::String {
+                    return Err(ShellError::MissingParameter(
-                        val: get_full_help(
+                        "needs filename".to_string(),
-                            &Open.signature(),
+                        call.head,
-                            &Open.examples(),
+                    ))
-                            engine_state,
-                            stack,
-                        ),
-                        span: call.head,
-                    }
-                    .into_pipeline_data())
                 }
                 PipelineData::Value(val, ..) => val.as_spanned_string()?,
                 _ => {
-                    return Ok(Value::String {
+                    return Err(ShellError::MissingParameter(
-                        val: get_full_help(
+                        "needs filename".to_string(),
-                            &Open.signature(),
+                        call.head,
-                            &Open.examples(),
+                    ));
-                            engine_state,
-                            stack,
-                        ),
-                        span: call.head,
-                    }
-                    .into_pipeline_data())
                 }
             }
         };

crates/nu-command/tests/commands/open.rs

@@ -299,3 +299,15 @@ fn open_ignore_ansi() {
         assert!(actual.err.is_empty());
     })
 }
+
+#[test]
+fn open_no_parameter() {
+    let actual = nu!(
+        cwd: "tests/fixtures/formats",
+        r#"
+            open
+        "#
+    );
+
+    assert!(actual.err.contains("needs filename"));
+}