extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-12 03:20:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add warning when using history isolation with non-SQLite history format (#16151)

Browse Source 
# Description
This PR depends on #16147, use `git diff 132ikl/shell-warning
132ikl/isolation-warn` to see only changes from this PR

People seem to get tripped up by this a lot, and it's not exactly
intuitive, so I added a warning if you try to set
`$env.config.history.isolation = true` when using the plaintext file
format:

    Warning: nu:🐚:invalid_config

      ⚠ Encountered 1 warnings(s) when updating config

    Warning: nu:🐚:incompatible_options

      ⚠ Incompatible options
       ╭─[source:1:33]
     1 │ $env.config.history.isolation = true
       ·                                 ──┬─
       ·                                   ╰── history isolation only compatible with SQLite format
       ╰────
      help: disable history isolation, or set $env.config.history.file_format = "sqlite"


# User-Facing Changes
* Added a warning when using history isolation without using SQLite
history.

# Tests + Formatting
Added a test
This commit is contained in:
132ikl
2025-07-15 09:40:32 -04:00
committed by GitHub
parent 59ad605e22
commit c4e8e040ce
11 changed files with 115 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/repl/test_config.rs
View File

@ -168,3 +168,11 @@ fn mutate_nu_config_plugin_gc_plugins() -> TestResult {
"0sec",
)
}
#[test]
fn mutate_nu_config_history_warning() -> TestResult {
fail_test(
r#"$env.config.history.file_format = "plaintext"; $env.config.history.isolation = true"#,
"history isolation only compatible with SQLite format",
)
}