From c504c93a1d16caf2c62a398999202cf895e69609 Mon Sep 17 00:00:00 2001 From: Jack Wright <56345+ayax79@users.noreply.github.com> Date: Wed, 19 Feb 2025 09:47:21 -0800 Subject: [PATCH] Polars: Minor code cleanup (#15144) # Description Removing todos and deadcode from a previous refactor --- crates/nu_plugin_polars/src/cache/mod.rs | 4 ++-- crates/nu_plugin_polars/src/dataframe/values/utils.rs | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/crates/nu_plugin_polars/src/cache/mod.rs b/crates/nu_plugin_polars/src/cache/mod.rs index 0fbf49f46f..49a76927e5 100644 --- a/crates/nu_plugin_polars/src/cache/mod.rs +++ b/crates/nu_plugin_polars/src/cache/mod.rs @@ -197,11 +197,11 @@ mod test { impl EngineWrapper for &MockEngineWrapper { fn get_env_var(&self, _key: &str) -> Option { - todo!() + unimplemented!() } fn use_color(&self) -> bool { - todo!() + unimplemented!() } fn set_gc_disabled(&self, disabled: bool) -> Result<(), ShellError> { diff --git a/crates/nu_plugin_polars/src/dataframe/values/utils.rs b/crates/nu_plugin_polars/src/dataframe/values/utils.rs index 52704b82cf..5db17afbee 100644 --- a/crates/nu_plugin_polars/src/dataframe/values/utils.rs +++ b/crates/nu_plugin_polars/src/dataframe/values/utils.rs @@ -6,8 +6,6 @@ pub const DEFAULT_ROWS: usize = 5; // Converts a Vec to a Vec> with a Span marking the whole // location of the columns for error referencing -// todo - fix -#[allow(dead_code)] pub(crate) fn convert_columns( columns: Vec, span: Span, @@ -49,8 +47,6 @@ pub(crate) fn convert_columns( // Converts a Vec to a Vec with a Span marking the whole // location of the columns for error referencing -// todo - fix -#[allow(dead_code)] pub(crate) fn convert_columns_string( columns: Vec, span: Span, @@ -92,8 +88,6 @@ pub(crate) fn convert_columns_string( // Converts a Vec to a Vec with a Span marking the whole // location of the columns for error referencing -// todo - fix -#[allow(dead_code)] pub(crate) fn convert_columns_sm_str( columns: Vec, span: Span,