From 40be4a2631e8612c8f1b773fc25aab104935df36 Mon Sep 17 00:00:00 2001 From: NotTheDr01ds <32344964+NotTheDr01ds@users.noreply.github.com> Date: Fri, 7 Mar 2025 10:30:50 -0500 Subject: [PATCH 1/2] Rename user-facing 'date' to 'datetime' --- crates/nu-cmd-lang/src/core_commands/describe.rs | 2 +- crates/nu-color-config/src/style_computer.rs | 2 +- crates/nu-command/src/conversions/into/value.rs | 6 +++--- crates/nu-command/tests/commands/table.rs | 8 ++++---- crates/nu-command/tests/format_conversions/nuon.rs | 2 +- crates/nu-protocol/src/signature.rs | 2 +- crates/nu-protocol/src/ty.rs | 4 ++-- crates/nu-protocol/src/value/mod.rs | 2 +- crates/nu-std/std/config/mod.nu | 4 ++-- crates/nu-utils/src/default_files/default_config.nu | 2 +- 10 files changed, 17 insertions(+), 17 deletions(-) diff --git a/crates/nu-cmd-lang/src/core_commands/describe.rs b/crates/nu-cmd-lang/src/core_commands/describe.rs index 375a840b16..b3f7b50611 100644 --- a/crates/nu-cmd-lang/src/core_commands/describe.rs +++ b/crates/nu-cmd-lang/src/core_commands/describe.rs @@ -103,7 +103,7 @@ impl Command for Describe { "category" => Value::test_string("default"), )), )), - "first_commit" => Value::test_string("date"), + "first_commit" => Value::test_string("datetime"), "my_duration" => Value::test_string("duration"), )), ))), diff --git a/crates/nu-color-config/src/style_computer.rs b/crates/nu-color-config/src/style_computer.rs index b055a6a46c..af467f31db 100644 --- a/crates/nu-color-config/src/style_computer.rs +++ b/crates/nu-color-config/src/style_computer.rs @@ -120,7 +120,7 @@ impl<'a> StyleComputer<'a> { ("int".to_string(), ComputableStyle::Static(Color::White.normal())), ("filesize".to_string(), ComputableStyle::Static(Color::Cyan.normal())), ("duration".to_string(), ComputableStyle::Static(Color::White.normal())), - ("date".to_string(), ComputableStyle::Static(Color::Purple.normal())), + ("datetime".to_string(), ComputableStyle::Static(Color::Purple.normal())), ("range".to_string(), ComputableStyle::Static(Color::White.normal())), ("float".to_string(), ComputableStyle::Static(Color::White.normal())), ("string".to_string(), ComputableStyle::Static(Color::White.normal())), diff --git a/crates/nu-command/src/conversions/into/value.rs b/crates/nu-command/src/conversions/into/value.rs index de371e27b9..eb2cf3a278 100644 --- a/crates/nu-command/src/conversions/into/value.rs +++ b/crates/nu-command/src/conversions/into/value.rs @@ -208,7 +208,7 @@ fn process_cell(val: Value, display_as_filesizes: bool, span: Span) -> Result Result Result "core", Category::Custom(name) => name, Category::Database => "database", - Category::Date => "date", + Category::Date => "datetime", Category::Debug => "debug", Category::Default => "default", Category::Deprecated => "deprecated", diff --git a/crates/nu-protocol/src/ty.rs b/crates/nu-protocol/src/ty.rs index 2308ce1579..72f5dbf905 100644 --- a/crates/nu-protocol/src/ty.rs +++ b/crates/nu-protocol/src/ty.rs @@ -135,7 +135,7 @@ impl Type { Type::Closure => String::from("closure"), Type::Bool => String::from("bool"), Type::CellPath => String::from("cell-path"), - Type::Date => String::from("date"), + Type::Date => String::from("datetime"), Type::Duration => String::from("duration"), Type::Filesize => String::from("filesize"), Type::Float => String::from("float"), @@ -162,7 +162,7 @@ impl Display for Type { Type::Closure => write!(f, "closure"), Type::Bool => write!(f, "bool"), Type::CellPath => write!(f, "cell-path"), - Type::Date => write!(f, "date"), + Type::Date => write!(f, "datetime"), Type::Duration => write!(f, "duration"), Type::Filesize => write!(f, "filesize"), Type::Float => write!(f, "float"), diff --git a/crates/nu-protocol/src/value/mod.rs b/crates/nu-protocol/src/value/mod.rs index 74c04327f1..9716d11cf8 100644 --- a/crates/nu-protocol/src/value/mod.rs +++ b/crates/nu-protocol/src/value/mod.rs @@ -324,7 +324,7 @@ impl Value { if let Value::Date { val, .. } = self { Ok(*val) } else { - self.cant_convert_to("date") + self.cant_convert_to("datetime") } } diff --git a/crates/nu-std/std/config/mod.nu b/crates/nu-std/std/config/mod.nu index 9b00db60db..ce4549d3be 100644 --- a/crates/nu-std/std/config/mod.nu +++ b/crates/nu-std/std/config/mod.nu @@ -13,7 +13,7 @@ export def dark-theme [] { int: white filesize: cyan duration: white - date: purple + datetime: purple range: white float: white string: white @@ -81,7 +81,7 @@ export def light-theme [] { int: dark_gray filesize: cyan_bold duration: dark_gray - date: purple + datetime: purple range: dark_gray float: dark_gray string: dark_gray diff --git a/crates/nu-utils/src/default_files/default_config.nu b/crates/nu-utils/src/default_files/default_config.nu index 8998c980d1..c5cd4b65fe 100644 --- a/crates/nu-utils/src/default_files/default_config.nu +++ b/crates/nu-utils/src/default_files/default_config.nu @@ -10,7 +10,7 @@ $env.config.color_config = { int: white filesize: cyan duration: white - date: purple + datetime: purple range: white float: white string: white From 301f2812a7346e3ac81ed59141df2ed085bce9a2 Mon Sep 17 00:00:00 2001 From: NotTheDr01ds <32344964+NotTheDr01ds@users.noreply.github.com> Date: Fri, 7 Mar 2025 10:37:27 -0500 Subject: [PATCH 2/2] Revert category change --- crates/nu-protocol/src/signature.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/nu-protocol/src/signature.rs b/crates/nu-protocol/src/signature.rs index ef43bce4f9..8405846eb2 100644 --- a/crates/nu-protocol/src/signature.rs +++ b/crates/nu-protocol/src/signature.rs @@ -83,7 +83,7 @@ impl std::fmt::Display for Category { Category::Core => "core", Category::Custom(name) => name, Category::Database => "database", - Category::Date => "datetime", + Category::Date => "date", Category::Debug => "debug", Category::Default => "default", Category::Deprecated => "deprecated",