extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-07-01 07:00:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

Reuse existing small allocations if possible (#12335)

Browse Source 
Those allocations are all small and insignificant in the grand scheme of
things and the optimizer may be able to resolve some of those but better
to be nice anyways.

Primarily inspired by the new
[`clippy::assigning_clones`](https://rust-lang.github.io/rust-clippy/master/index.html#/assigning_clones)

- **Avoid reallocs with `clone_from` in `nu-parser`**
- **Avoid realloc on assignment in `Stack`**
- **Fix `clippy::assigning_clones` in `nu-cli`**
- **Reuse allocations in `nu-explore` if possible**
This commit is contained in:
Stefan Holderbach
2024-03-30 14:04:11 +01:00
committed by GitHub
parent ce581a80a6
commit cc39069e13
8 changed files with 28 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
crates/nu-parser/src/parse_keywords.rs
View File

@ -592,7 +592,7 @@ pub fn parse_def(
if let Some(decl_id) = working_set.find_predecl(name.as_bytes()) {
let declaration = working_set.get_decl_mut(decl_id);
signature.name = name.clone();
signature.name.clone_from(&name);
if !has_wrapped {
*signature = signature.add_help();
}
@ -751,9 +751,9 @@ pub fn parse_extern(
name.clone()
};
signature.name = external_name.clone();
signature.usage = usage.clone();
signature.extra_usage = extra_usage.clone();
signature.name.clone_from(&external_name);
signature.usage.clone_from(&usage);
signature.extra_usage.clone_from(&extra_usage);
signature.allows_unknown_args = true;
if let Some(block_id) = body.and_then(|x| x.as_block()) {
@ -1233,7 +1233,7 @@ pub fn parse_export_in_module(
// Trying to warp the 'def' call into the 'export def' in a very clumsy way
if let Some(Expr::Call(def_call)) = pipeline.elements.first().map(|e| &e.expr.expr)
{
call = def_call.clone();
call.clone_from(def_call);
call.head = span(&spans[0..=1]);
call.decl_id = export_def_decl_id;
} else {
@ -1269,7 +1269,7 @@ pub fn parse_export_in_module(
// Trying to warp the 'def' call into the 'export def' in a very clumsy way
if let Some(Expr::Call(def_call)) = pipeline.elements.first().map(|e| &e.expr.expr)
{
call = def_call.clone();
call.clone_from(def_call);
call.head = span(&spans[0..=1]);
call.decl_id = export_def_decl_id;
} else {
@ -1325,7 +1325,7 @@ pub fn parse_export_in_module(
if let Some(Expr::Call(alias_call)) =
pipeline.elements.first().map(|e| &e.expr.expr)
{
call = alias_call.clone();
call.clone_from(alias_call);
call.head = span(&spans[0..=1]);
call.decl_id = export_alias_decl_id;
@ -1380,7 +1380,7 @@ pub fn parse_export_in_module(
// Trying to warp the 'use' call into the 'export use' in a very clumsy way
if let Some(Expr::Call(use_call)) = pipeline.elements.first().map(|e| &e.expr.expr)
{
call = use_call.clone();
call.clone_from(use_call);
call.head = span(&spans[0..=1]);
call.decl_id = export_use_decl_id;
@ -1412,7 +1412,7 @@ pub fn parse_export_in_module(
if let Some(Expr::Call(module_call)) =
pipeline.elements.first().map(|e| &e.expr.expr)
{
call = module_call.clone();
call.clone_from(module_call);
call.head = span(&spans[0..=1]);
call.decl_id = export_module_decl_id;
@ -1463,7 +1463,7 @@ pub fn parse_export_in_module(
// Trying to warp the 'const' call into the 'export const' in a very clumsy way
if let Some(Expr::Call(def_call)) = pipeline.elements.first().map(|e| &e.expr.expr)
{
call = def_call.clone();
call.clone_from(def_call);
call.head = span(&spans[0..=1]);
call.decl_id = export_const_decl_id;