mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 22:50:14 +02:00
Fix capture logic for inner closures (#9754)
# Description This fixes the variable capture logic for closures in two cases: * Closures inside of closures did not properly register the closures (or lack thereof) in the outer closure * Closures which called their inner closures before definition did not properly calculate the closures of the outer closure Example of the first case: ``` do { let b = 3; def c [] { $b }; c } ``` Example of the second case (notice `c` is called before it is defined): ``` do { let b = 3; c; def c [] { $b }; c } ``` # User-Facing Changes This should strictly allow closures to work more correctly. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -655,3 +655,13 @@ fn def_with_in_var_mut_2() -> TestResult {
|
||||
"3",
|
||||
)
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn properly_nest_captures() -> TestResult {
|
||||
run_test(r#"do { let b = 3; def c [] { $b }; c }"#, "3")
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn properly_nest_captures_call_first() -> TestResult {
|
||||
run_test(r#"do { let b = 3; c; def c [] { $b }; c }"#, "3")
|
||||
}
|
||||
|
Reference in New Issue
Block a user