mirror of
https://github.com/nushell/nushell.git
synced 2025-08-09 19:07:42 +02:00
fix semicolon doesn't work for some commands (#7373)
# Description Fix semicolon working for the following commands which runs to failed: 1. into record (example: `into record; echo 'aa'`) -- the final aa shouldn't be printed 2. save ( example: `touch a; chmod a-w a; echo 'aa' | save a; echo asdf` ) -- the final asdf shouldn't be printed 3. fetch ( example: `touch a; chmod a-w a; fetch https://www.google.com -o a; echo asdf` ) -- the final asdf shouldn't be printed 4. registry_query (I don't have window machine, sorry for that I can't demo for it) I've reviewed most of built-in commands, and it seems that other commands works fine. # User-Facing Changes # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -135,17 +135,12 @@ impl Command for SubCommand {
|
||||
Err(err) => {
|
||||
let arg_span =
|
||||
call.get_named_arg("output").expect("arg should exist").span;
|
||||
return Ok(PipelineData::Value(
|
||||
Value::Error {
|
||||
error: ShellError::GenericError(
|
||||
"Permission denied".into(),
|
||||
err.to_string(),
|
||||
Some(arg_span),
|
||||
None,
|
||||
Vec::new(),
|
||||
),
|
||||
},
|
||||
return Err(ShellError::GenericError(
|
||||
"Permission denied".into(),
|
||||
err.to_string(),
|
||||
Some(arg_span),
|
||||
None,
|
||||
Vec::new(),
|
||||
));
|
||||
}
|
||||
};
|
||||
|
Reference in New Issue
Block a user