revert changes on prepend and append (#7660)

# Description

#7623 causes a break on PATH convertion, this pr is going to revert
`prepend` and `append` bahavior.

# User-Facing Changes

_(List of all changes that impact the user experience here. This helps
us keep track of breaking changes.)_

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
WindSoilder 2023-01-03 09:09:55 +08:00 committed by GitHub
parent 65d0b5b9d9
commit d1a78a58cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 2 additions and 16 deletions

View File

@ -99,7 +99,7 @@ only unwrap the outer list, and leave the variable's contents untouched."#
let metadata = input.metadata(); let metadata = input.metadata();
Ok(input Ok(input
.into_iter_strict(call.head)? .into_iter()
.chain(vec) .chain(vec)
.into_iter() .into_iter()
.into_pipeline_data(engine_state.ctrlc.clone()) .into_pipeline_data(engine_state.ctrlc.clone())

View File

@ -105,7 +105,7 @@ only unwrap the outer list, and leave the variable's contents untouched."#
Ok(vec Ok(vec
.into_iter() .into_iter()
.chain(input.into_iter_strict(call.head)?) .chain(input.into_iter())
.into_iter() .into_iter()
.into_pipeline_data(engine_state.ctrlc.clone()) .into_pipeline_data(engine_state.ctrlc.clone())
.set_metadata(metadata)) .set_metadata(metadata))

View File

@ -13,10 +13,3 @@ fn adds_a_row_to_the_end() {
assert_eq!(actual.out, "pollo loco"); assert_eq!(actual.out, "pollo loco");
} }
#[test]
fn fail_on_non_iterator() {
let actual = nu!(cwd: ".", pipeline("1 | append 3"));
assert!(actual.err.contains("only_supports_this_input_type"));
}

View File

@ -27,10 +27,3 @@ fn adds_a_row_to_the_beginning() {
assert_eq!(actual.out, "pollo loco"); assert_eq!(actual.out, "pollo loco");
}) })
} }
#[test]
fn fail_on_non_iterator() {
let actual = nu!(cwd: ".", pipeline("1 | prepend 4"));
assert!(actual.err.contains("only_supports_this_input_type"));
}