From d3f22588f0c4bb283dcb1f00d07aa5e5d1b8438d Mon Sep 17 00:00:00 2001 From: Stefan Holderbach Date: Wed, 13 Mar 2024 19:42:31 +0100 Subject: [PATCH] Disable `fmt` feature of `polars(-core)` (#12151) In normal operations we don't display the dataframes directly. The `fmt` feature on `polars-core` pulls in the `comfy-table` crate with its own dependencies on `crossterm` and `strum(_macros)`. This has the chance to duplicate dependencies. (currently strum version divergence) Without this feature only the shapes should be displayed. May degrade the error output during testing. --- Cargo.lock | 25 +++---------------------- crates/nu-cmd-dataframe/Cargo.toml | 3 ++- 2 files changed, 5 insertions(+), 23 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index a849fb6724..23baafeca5 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -773,18 +773,6 @@ version = "1.0.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "acbf1af155f9b9ef647e42cdc158db4b64a1b61f743629225fde6f3e0be2a7c7" -[[package]] -name = "comfy-table" -version = "7.1.0" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "7c64043d6c7b7a4c58e39e7efccfdea7b93d885a795d0c054a69dbbf4dd52686" -dependencies = [ - "crossterm", - "strum 0.25.0", - "strum_macros 0.25.3", - "unicode-width", -] - [[package]] name = "compact_str" version = "0.7.1" @@ -3098,7 +3086,7 @@ dependencies = [ "rstest", "serde", "serde_json", - "strum 0.26.1", + "strum", "strum_macros 0.26.1", "thiserror", "typetag", @@ -3855,7 +3843,6 @@ dependencies = [ "bytemuck", "chrono", "chrono-tz", - "comfy-table", "either", "hashbrown 0.14.3", "indexmap", @@ -4467,7 +4454,7 @@ dependencies = [ "lru", "paste", "stability", - "strum 0.26.1", + "strum", "unicode-segmentation", "unicode-width", ] @@ -4527,7 +4514,7 @@ dependencies = [ "serde", "serde_json", "strip-ansi-escapes", - "strum 0.26.1", + "strum", "strum_macros 0.26.1", "thiserror", "unicode-segmentation", @@ -5336,12 +5323,6 @@ version = "0.10.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "73473c0e59e6d5812c5dfe2a064a6444949f089e20eec9a2e5506596494e4623" -[[package]] -name = "strum" -version = "0.25.0" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "290d54ea6f91c969195bdbcd7442c8c2a2ba87da8bf60a7ee86a235d4bc1e125" - [[package]] name = "strum" version = "0.26.1" diff --git a/crates/nu-cmd-dataframe/Cargo.toml b/crates/nu-cmd-dataframe/Cargo.toml index 47004f56a0..24789971de 100644 --- a/crates/nu-cmd-dataframe/Cargo.toml +++ b/crates/nu-cmd-dataframe/Cargo.toml @@ -39,7 +39,6 @@ features = [ "cross_join", "csv", "cum_agg", - "default", "dtype-categorical", "dtype-datetime", "dtype-struct", @@ -60,8 +59,10 @@ features = [ "serde", "serde-lazy", "strings", + "temporal", "to_dummies", ] +default-features = false optional = true version = "0.37"