extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-05-11 21:44:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(parser): namespace pollution of constants by use module_name

Browse Source
This commit is contained in:
blindfs 2025-04-07 20:31:35 +08:00
parent 0f8f3bcf9a
commit d6e6a90b3a
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crates/nu-protocol/src/module.rs
View File

@ -128,7 +128,6 @@ impl Module {
} else { } else {
// Import pattern was just name without any members // Import pattern was just name without any members
let mut decls = vec![]; let mut decls = vec![];
let mut const_vids = vec![];
let mut const_rows = vec![]; let mut const_rows = vec![];
let mut errors = vec![]; let mut errors = vec![];
@ -154,7 +153,6 @@ impl Module {
decls.push((new_name, sub_decl_id)); decls.push((new_name, sub_decl_id));
} }
const_vids.extend(sub_results.constants);
const_rows.extend(sub_results.constant_values); const_rows.extend(sub_results.constant_values);
} }
@ -162,10 +160,7 @@ impl Module {
for (name, var_id) in self.consts() { for (name, var_id) in self.consts() {
match working_set.get_constant(var_id) { match working_set.get_constant(var_id) {
Ok(const_val) => { Ok(const_val) => const_rows.push((name, const_val.clone())),
const_vids.push((name.clone(), var_id));
const_rows.push((name, const_val.clone()))
}
Err(err) => errors.push(err), Err(err) => errors.push(err),
} }
} }
@ -192,7 +187,7 @@ impl Module {
ResolvedImportPattern::new( ResolvedImportPattern::new(
decls, decls,
vec![(final_name.clone(), self_id)], vec![(final_name.clone(), self_id)],
const_vids, vec![],
constant_values, constant_values,
), ),
errors, errors,