extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-01-03 04:50:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

You will now receive an error when trying to use a s3 url with avro or json

Browse Source
This commit is contained in:
Jack Wright 2024-12-20 17:25:25 -08:00
parent 13bc9508d0
commit d723a4e77e
2 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
crates/nu_plugin_polars/src/dataframe/command/core/open.rs
View File

@ -295,6 +295,10 @@ fn from_avro(
) -> Result<Value, ShellError> { ) -> Result<Value, ShellError> {
let file_path = resource.path; let file_path = resource.path;
let file_span = resource.span; let file_span = resource.span;
if resource.cloud_options.is_some() {
return Err(cloud_not_supported(PolarsFileType::Avro, file_span));
}
let columns: Option<Vec<String>> = call.get_flag("columns")?; let columns: Option<Vec<String>> = call.get_flag("columns")?;
let r = File::open(file_path).map_err(|e| ShellError::GenericError { let r = File::open(file_path).map_err(|e| ShellError::GenericError {
error: "Error opening file".into(), error: "Error opening file".into(),
@ -396,6 +400,9 @@ fn from_json(
) -> Result<Value, ShellError> { ) -> Result<Value, ShellError> {
let file_path = resource.path; let file_path = resource.path;
let file_span = resource.span; let file_span = resource.span;
if resource.cloud_options.is_some() {
return Err(cloud_not_supported(PolarsFileType::Json, file_span));
}
let file = File::open(file_path).map_err(|e| ShellError::GenericError { let file = File::open(file_path).map_err(|e| ShellError::GenericError {
error: "Error opening file".into(), error: "Error opening file".into(),
msg: e.to_string(), msg: e.to_string(),
@ -631,3 +638,16 @@ fn from_csv(
df.cache_and_to_value(plugin, engine, call.head) df.cache_and_to_value(plugin, engine, call.head)
} }
} }
fn cloud_not_supported(file_type: PolarsFileType, span: Span) -> ShellError {
ShellError::GenericError {
error: format!(
"Cloud operations not supported for file type {}",
file_type.to_str()
),
msg: "".into(),
span: Some(span),
help: None,
inner: vec![],
}
}

9
crates/nu_plugin_polars/src/dataframe/values/file_type.rs
View File

@ -24,9 +24,12 @@ impl PolarsFileType {
.collect::<Vec<&'static str>>() .collect::<Vec<&'static str>>()
.join(", "); .join(", ");
ShellError::FileNotFoundCustom { ShellError::GenericError {
msg: format!("Unsupported type {extension} expected {type_string}"), error: format!("Unsupported type {extension} expected {type_string}"),
span, msg: "".into(),
span: Some(span),
help: None,
inner: vec![],
} }
} }