From d7cec2088a65f8206bf9322969cd462d359f63f2 Mon Sep 17 00:00:00 2001 From: liquid-dragons <93494392+liquid-dragons@users.noreply.github.com> Date: Thu, 12 Jun 2025 20:34:52 +0200 Subject: [PATCH] Fix docs typo referring to non-existant `Value::CustomValue` (#15954) # Description I was messing around with custom types and noticed `nu-protocol` referring to a `Value::CustomValue` variant that doesn't exist. Fixed it to say `Value::Custom` instead. # User-Facing Changes Documentation mentions the correct variant of `Value` # Tests + Formatting No new tests necessary # After Submitting --- crates/nu-protocol/src/value/custom_value.rs | 2 +- crates/nu-protocol/src/value/mod.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/nu-protocol/src/value/custom_value.rs b/crates/nu-protocol/src/value/custom_value.rs index 2f02af1aac..c28c1e637f 100644 --- a/crates/nu-protocol/src/value/custom_value.rs +++ b/crates/nu-protocol/src/value/custom_value.rs @@ -7,7 +7,7 @@ use crate::{ShellError, Span, Type, Value, ast::Operator}; pub trait CustomValue: fmt::Debug + Send + Sync { /// Custom `Clone` implementation /// - /// This can reemit a `Value::CustomValue(Self, span)` or materialize another representation + /// This can reemit a `Value::Custom(Self, span)` or materialize another representation /// if necessary. fn clone_value(&self, span: Span) -> Value; diff --git a/crates/nu-protocol/src/value/mod.rs b/crates/nu-protocol/src/value/mod.rs index 567c36263e..b92a527cea 100644 --- a/crates/nu-protocol/src/value/mod.rs +++ b/crates/nu-protocol/src/value/mod.rs @@ -1981,7 +1981,7 @@ impl Value { /// as it will point into unknown source when used in errors. /// /// Returns a `Vec` containing one of each value case (`Value::Int`, `Value::String`, etc.) - /// except for `Value::CustomValue`. + /// except for `Value::Custom`. pub fn test_values() -> Vec { vec![ Value::test_bool(false),