From d9d9916ccceadd797f6ede148e8be6339bb25620 Mon Sep 17 00:00:00 2001
From: Reilly Wood <26268125+rgwood@users.noreply.github.com>
Date: Tue, 13 Dec 2022 19:45:37 -0800
Subject: [PATCH] Fix streaming page missing newline (#7466)

Fixes #7342. `0..1000 | table` before this change:


![image](https://user-images.githubusercontent.com/26268125/207474492-dead4267-d828-4840-8da0-4edfda3e3916.png)

`0..1000 | table` after this change:


![image](https://user-images.githubusercontent.com/26268125/207474583-26633db0-46c5-4c30-8681-654855e7042b.png)

When piping data to `table`, pages were not getting a newline at the
end[^1]. This problem was uncovered and exacerbated by the new
`display_output` hook which implicitly piped _everything_ to `table`.

## The Fix

`PagingTableCreator` now adds a newline to each page instead of relying
on later code to do it.

## Tests

I spent a while trying to write a regression test for this behaviour but
I couldn't get the test to fail before my fix! I think the test
infrastructure does something special with newlines when it's checking
command output. I eventually ran out of steam trying to investigate
that, sorry.

[^1]: unless the pipe to table was the implicit one that's done when
there is no `display_output` hook set. That situation was still working
OK.
---
 crates/nu-cli/src/util.rs              | 2 +-
 crates/nu-command/src/viewers/table.rs | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/crates/nu-cli/src/util.rs b/crates/nu-cli/src/util.rs
index dd9fd32a5d..39ff70c14b 100644
--- a/crates/nu-cli/src/util.rs
+++ b/crates/nu-cli/src/util.rs
@@ -250,7 +250,7 @@ pub fn eval_source(
                     }
                 }
             } else {
-                result = pipeline_data.print(engine_state, stack, false, false);
+                result = pipeline_data.print(engine_state, stack, true, false);
             }
 
             match result {
diff --git a/crates/nu-command/src/viewers/table.rs b/crates/nu-command/src/viewers/table.rs
index d66589b4b5..ad60e38be7 100644
--- a/crates/nu-command/src/viewers/table.rs
+++ b/crates/nu-command/src/viewers/table.rs
@@ -1616,7 +1616,11 @@ impl Iterator for PagingTableCreator {
         self.row_offset += idx;
 
         match table {
-            Ok(Some(table)) => Some(Ok(table.as_bytes().to_vec())),
+            Ok(Some(table)) => {
+                let mut bytes = table.as_bytes().to_vec();
+                bytes.push(b'\n'); // tabled tables don't come with a newline on the end
+                Some(Ok(bytes))
+            }
             Err(err) => Some(Err(err)),
             _ => None,
         }