mirror of
https://github.com/nushell/nushell.git
synced 2025-08-10 20:24:24 +02:00
feat(where): Support stored closure (#15697)
# Description - `where` used to be able to filter using stored closures at some point using a flag. > #5955 - This was later removed and `filter` command added to cover the use case. > #7365 This PR once again allows using `where` with closures stored in variables. ```nushell let cond = { $in mod 2 == 0 } 1..10 | where $cond # => ╭───┬────╮ # => │ 0 │ 2 │ # => │ 1 │ 4 │ # => │ 2 │ 6 │ # => │ 3 │ 8 │ # => │ 4 │ 10 │ # => ╰───┴────╯ let nested = {cond: { $in mod 2 == 0 }} 1..10 | where $nested.cond # => ╭───┬────╮ # => │ 0 │ 2 │ # => │ 1 │ 4 │ # => │ 2 │ 6 │ # => │ 3 │ 8 │ # => │ 4 │ 10 │ # => ╰───┴────╯ ``` This does not interfere with using `$it` or one of its fields as the condition. ```nushell [[name state]; [foo true] [bar false] [baz true] [quox false]] | where $it.state # => ╭───┬──────┬───────╮ # => │ # │ name │ state │ # => ├───┼──────┼───────┤ # => │ 0 │ foo │ true │ # => │ 1 │ baz │ true │ # => ╰───┴──────┴───────╯ ``` This change obsoletes `filter`, deprecate it in the future? # User-Facing Changes # Tests + Formatting Added examples and tests. - 🟢 toolkit fmt - 🟢 toolkit clippy - 🟢 toolkit test - 🟢 toolkit test stdlib # After Submitting --------- Co-authored-by: Bahex <17417311+Bahex@users.noreply.github.com>
This commit is contained in:
@ -35,7 +35,10 @@ not supported."#
|
||||
])
|
||||
.required(
|
||||
"row_condition",
|
||||
SyntaxShape::RowCondition,
|
||||
SyntaxShape::OneOf(vec![
|
||||
SyntaxShape::RowCondition,
|
||||
SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
|
||||
]),
|
||||
"Filter condition.",
|
||||
)
|
||||
.allow_variants_without_examples(true)
|
||||
@ -122,6 +125,21 @@ not supported."#
|
||||
example: "ls | where name =~ '(?i)readme'",
|
||||
result: None,
|
||||
},
|
||||
Example {
|
||||
description: "Filter rows of a table according to a stored condition",
|
||||
example: "let cond = {|x| $x.a > 1}; [{a: 1} {a: 2}] | where $cond",
|
||||
result: Some(Value::test_list(vec![Value::test_record(record! {
|
||||
"a" => Value::test_int(2),
|
||||
})])),
|
||||
},
|
||||
Example {
|
||||
description: "List all numbers above 3, using an existing closure condition",
|
||||
example: "let a = {$in > 3}; [1, 2, 5, 6] | where $a",
|
||||
result: Some(Value::test_list(vec![
|
||||
Value::test_int(5),
|
||||
Value::test_int(6),
|
||||
])),
|
||||
},
|
||||
]
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user