extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 11:45:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change type of parameter default values to Option<Value> (#8940)

Browse Source 
# Description

Fixes #8939.

# User-Facing Changes

- Parameter default values will now be parsed as constants.
- If the default value is not a constant, a parser error is displayed.

# Tests + Formatting

The [only affected
test](d42c2b2dbc/src/tests/test_engine.rs (L325-L328))
has been updated to reflect the new behavior.
This commit is contained in:
Maria José Solano
2023-04-26 07:14:02 -07:00
committed by GitHub
parent 77ca73f414
commit e251f3a0b4
5 changed files with 31 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
crates/nu-engine/src/eval.rs
View File

@ -72,9 +72,8 @@ pub fn eval_call(
if let Some(arg) = call.positional_nth(param_idx) {
let result = eval_expression(engine_state, caller_stack, arg)?;
callee_stack.add_var(var_id, result);
} else if let Some(arg) = &param.default_value {
let result = eval_expression(engine_state, caller_stack, arg)?;
callee_stack.add_var(var_id, result);
} else if let Some(value) = &param.default_value {
callee_stack.add_var(var_id, value.to_owned());
} else {
callee_stack.add_var(var_id, Value::nothing(call.head));
}