extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-07-01 07:00:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

Display empty records and lists (#7925)

Browse Source 
# Description

Fix some issues related to #7444 
1. Empty lists and records are now displayed as a small notice in a box:

![image](https://user-images.githubusercontent.com/17511668/215832023-3f8d743a-2899-416f-9109-7876ad2bbedf.png)

![image](https://user-images.githubusercontent.com/17511668/215832273-c737b8a4-af33-4c16-8dd3-bd4f0fd19b5a.png)
2. Empty records are now correctly displayed if inside of another record
list or table:

![image](https://user-images.githubusercontent.com/17511668/215832597-00f0cebc-a3b6-4ce8-8373-a9340d4c7020.png)

![image](https://user-images.githubusercontent.com/17511668/215832540-ab0e2a14-b8f6-4f47-976c-42003b622ef6.png)
3. Fixed inconsistent coloring of empty list placeholder inside of
lists/tables:

![image](https://user-images.githubusercontent.com/17511668/215832924-813ffe17-e04e-4301-97c3-1bdbccf1825c.png)

![image](https://user-images.githubusercontent.com/17511668/215832963-4765c4cf-3036-4bcc-81e1-ced941fa47cb.png)


# User-Facing Changes

`table` command now displays empty records and lists like a table with
text and correctly displays empty records inside tables and lists.

New behavior of displaying empty lists and records can be disabled using
`table.show_empty` config option.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
Artemiy
2023-02-22 19:18:33 +03:00
committed by GitHub
parent 0ab6b66d8f
commit e389e51b2b
10 changed files with 256 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
crates/nu-command/tests/commands/table.rs
View File

@ -1380,10 +1380,8 @@ fn table_expande_with_no_header_internally_0() {
"│ │ │ │ │ highlight │ │ bg │ yellow │ │ │ │",
"│ │ │ │ │ │ │ fg │ black │ │ │ │",
"│ │ │ │ │ │ ╰────┴────────╯ │ │ │",
"│ │ │ │ │ │ │ │ │",
"│ │ │ │ │ status │ │ │ │",
"│ │ │ │ │ │ │ │ │",
"│ │ │ │ │ try │ │ │ │",
"│ │ │ │ │ status │ {record 0 fields} │ │ │",
"│ │ │ │ │ try │ {record 0 fields} │ │ │",
"│ │ │ │ │ │ ╭──────────────────┬─────────╮ │ │ │",
"│ │ │ │ │ table │ │ split_line │ #404040 │ │ │ │",
"│ │ │ │ │ │ │ cursor │ true │ │ │ │",
@ -1624,10 +1622,8 @@ fn table_expande_with_no_header_internally_1() {
"│ │ │ │ │ highlight │ │ bg │ yellow │ │ │ │",
"│ │ │ │ │ │ │ fg │ black │ │ │ │",
"│ │ │ │ │ │ ╰────┴────────╯ │ │ │",
"│ │ │ │ │ │ │ │ │",
"│ │ │ │ │ status │ │ │ │",
"│ │ │ │ │ │ │ │ │",
"│ │ │ │ │ try │ │ │ │",
"│ │ │ │ │ status │ {record 0 fields} │ │ │",
"│ │ │ │ │ try │ {record 0 fields} │ │ │",
"│ │ │ │ │ │ ╭──────────────────┬─────────╮ │ │ │",
"│ │ │ │ │ table │ │ split_line │ #404040 │ │ │ │",
"│ │ │ │ │ │ │ cursor │ true │ │ │ │",