External vars (#1615)

* fix empty table and missing spans

* wip

* WIP

* WIP

* working version with vars

* tidying

* WIP

* Fix external quoting issue
This commit is contained in:
Jonathan Turner
2020-04-21 09:45:11 +12:00
committed by GitHub
parent 2ffb14c7d0
commit e4fdb36511
6 changed files with 126 additions and 352 deletions

View File

@ -1,5 +1,5 @@
use nu_protocol::hir::{ExternalArg, ExternalArgs, ExternalCommand};
use nu_source::{Span, SpannedItem, Tag, TaggedItem};
use nu_protocol::hir::{Expression, ExternalArgs, ExternalCommand, SpannedExpression};
use nu_source::{Span, SpannedItem, Tag};
pub struct ExternalBuilder {
name: String,
@ -28,13 +28,9 @@ impl ExternalBuilder {
let args = self
.args
.iter()
.map(|arg| {
let arg = arg.tagged(Tag::unknown());
ExternalArg {
arg: arg.to_string(),
tag: arg.tag,
}
.map(|arg| SpannedExpression {
expr: Expression::string(arg.to_string()),
span: Span::unknown(),
})
.collect::<Vec<_>>();