extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-15 21:07:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address lints from clippy for beta/nightly (#5709)

Browse Source 
* Fix clippy lints in tests

* Replace `format!` in `.push_str()` with `write!`

Stylistically that might be a bit rough but elides an allocation.

Fallibility of allocation is more explicit, but ignored with `let _ =`
like in the clippy example:

https://rust-lang.github.io/rust-clippy/master/index.html#format_push_string

* Remove unused lifetime

* Fix macro crate relative import

* Derive `Eq` for `PartialEq` with `Eq` members

https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

* Remove unnnecessary `.to_string()` for Cow<str>

* Remove `.to_string()` for `tendril::Tendril`

Implements `Deref<Target = str>`
This commit is contained in:
Stefan Holderbach
2022-06-04 08:47:36 +02:00
committed by GitHub
parent a82fa75c31
commit e5d38dcff6
27 changed files with 81 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/nu-cli/tests/custom_completions.rs
View File

@ -18,7 +18,7 @@ fn variables_completions() {
let mut completer = NuCompleter::new(std::sync::Arc::new(engine), stack);
// Test completions for $nu
let suggestions = completer.complete("my-command ".into(), 11);
let suggestions = completer.complete("my-command ", 11);
assert_eq!(3, suggestions.len());

2
crates/nu-cli/tests/flag_completions.rs
View File

@ -12,7 +12,7 @@ fn flag_completions() {
// Instatiate a new completer
let mut completer = NuCompleter::new(std::sync::Arc::new(engine), stack);
// Test completions for the 'ls' flags
let suggestions = completer.complete("ls -".into(), 4);
let suggestions = completer.complete("ls -", 4);
assert_eq!(12, suggestions.len());

4
crates/nu-cli/tests/support/completions_helpers.rs
View File

@ -89,7 +89,7 @@ pub fn merge_input(
dir: PathBuf,
) -> Result<(), ShellError> {
let (block, delta) = {
let mut working_set = StateWorkingSet::new(&engine_state);
let mut working_set = StateWorkingSet::new(engine_state);
let (block, err) = parse(&mut working_set, None, input, false, &[]);
@ -98,7 +98,7 @@ pub fn merge_input(
(block, working_set.render())
};
assert!(eval_block(
&engine_state,
engine_state,
stack,
&block,
PipelineData::Value(

12
crates/nu-cli/tests/variables_completions.rs
View File

@ -17,7 +17,7 @@ fn variables_completions() {
let mut completer = NuCompleter::new(std::sync::Arc::new(engine), stack);
// Test completions for $nu
let suggestions = completer.complete("$nu.".into(), 4);
let suggestions = completer.complete("$nu.", 4);
assert_eq!(8, suggestions.len());
@ -36,7 +36,7 @@ fn variables_completions() {
match_suggestions(expected, suggestions);
// Test completions for $nu.h (filter)
let suggestions = completer.complete("$nu.h".into(), 5);
let suggestions = completer.complete("$nu.h", 5);
assert_eq!(2, suggestions.len());
@ -46,7 +46,7 @@ fn variables_completions() {
match_suggestions(expected, suggestions);
// Test completions for custom var
let suggestions = completer.complete("$actor.".into(), 7);
let suggestions = completer.complete("$actor.", 7);
assert_eq!(2, suggestions.len());
@ -56,7 +56,7 @@ fn variables_completions() {
match_suggestions(expected, suggestions);
// Test completions for custom var (filtering)
let suggestions = completer.complete("$actor.n".into(), 7);
let suggestions = completer.complete("$actor.n", 7);
assert_eq!(1, suggestions.len());
@ -66,7 +66,7 @@ fn variables_completions() {
match_suggestions(expected, suggestions);
// Test completions for $env
let suggestions = completer.complete("$env.".into(), 5);
let suggestions = completer.complete("$env.", 5);
assert_eq!(2, suggestions.len());
@ -76,7 +76,7 @@ fn variables_completions() {
match_suggestions(expected, suggestions);
// Test completions for $env
let suggestions = completer.complete("$env.T".into(), 5);
let suggestions = completer.complete("$env.T", 5);
assert_eq!(1, suggestions.len());