extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-12 12:27:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address lints from clippy for beta/nightly (#5709)

Browse Source 
* Fix clippy lints in tests

* Replace `format!` in `.push_str()` with `write!`

Stylistically that might be a bit rough but elides an allocation.

Fallibility of allocation is more explicit, but ignored with `let _ =`
like in the clippy example:

https://rust-lang.github.io/rust-clippy/master/index.html#format_push_string

* Remove unused lifetime

* Fix macro crate relative import

* Derive `Eq` for `PartialEq` with `Eq` members

https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

* Remove unnnecessary `.to_string()` for Cow<str>

* Remove `.to_string()` for `tendril::Tendril`

Implements `Deref<Target = str>`
This commit is contained in:
Stefan Holderbach
2022-06-04 08:47:36 +02:00
committed by GitHub
parent a82fa75c31
commit e5d38dcff6
27 changed files with 81 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/nu-json/src/value.rs
View File

@ -974,7 +974,7 @@ struct VariantDeserializer {
val: Option<Value>,
}
impl<'de, 'a> de::VariantAccess<'de> for VariantDeserializer {
impl<'de> de::VariantAccess<'de> for VariantDeserializer {
type Error = Error;
fn unit_variant(self) -> Result<()> {
@ -1062,7 +1062,7 @@ struct MapDeserializer {
value: Option<Value>,
}
impl<'de, 'a> de::MapAccess<'de> for MapDeserializer {
impl<'de> de::MapAccess<'de> for MapDeserializer {
type Error = Error;
fn next_key_seed<K>(&mut self, seed: K) -> Result<Option<K::Value>>