mirror of
https://github.com/nushell/nushell.git
synced 2025-08-19 04:06:39 +02:00
Address lints from clippy for beta/nightly (#5709)
* Fix clippy lints in tests * Replace `format!` in `.push_str()` with `write!` Stylistically that might be a bit rough but elides an allocation. Fallibility of allocation is more explicit, but ignored with `let _ =` like in the clippy example: https://rust-lang.github.io/rust-clippy/master/index.html#format_push_string * Remove unused lifetime * Fix macro crate relative import * Derive `Eq` for `PartialEq` with `Eq` members https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq * Remove unnnecessary `.to_string()` for Cow<str> * Remove `.to_string()` for `tendril::Tendril` Implements `Deref<Target = str>`
This commit is contained in:
committed by
GitHub
parent
a82fa75c31
commit
e5d38dcff6
@@ -138,7 +138,7 @@ pub enum Alignment {
|
||||
/// The easiest way to create a Cell is just by using `string.into()`, which
|
||||
/// uses the **unicode width** of the string (see the `unicode_width` crate).
|
||||
/// However, the fields are public, if you wish to provide your own length.
|
||||
#[derive(PartialEq, Debug, Clone)]
|
||||
#[derive(PartialEq, Eq, Debug, Clone)]
|
||||
pub struct Cell {
|
||||
/// The string to display when this cell gets rendered.
|
||||
pub contents: String,
|
||||
@@ -171,7 +171,7 @@ impl<'a> From<&'a str> for Cell {
|
||||
}
|
||||
|
||||
/// Direction cells should be written in — either across, or downwards.
|
||||
#[derive(PartialEq, Debug, Copy, Clone)]
|
||||
#[derive(PartialEq, Eq, Debug, Copy, Clone)]
|
||||
pub enum Direction {
|
||||
/// Starts at the top left and moves rightwards, going back to the first
|
||||
/// column for a new row, like a typewriter.
|
||||
@@ -187,7 +187,7 @@ pub type Width = usize;
|
||||
|
||||
/// The text to put in between each pair of columns.
|
||||
/// This does not include any spaces used when aligning cells.
|
||||
#[derive(PartialEq, Debug)]
|
||||
#[derive(PartialEq, Eq, Debug)]
|
||||
pub enum Filling {
|
||||
/// A certain number of spaces should be used as the separator.
|
||||
Spaces(Width),
|
||||
@@ -208,7 +208,7 @@ impl Filling {
|
||||
|
||||
/// The user-assignable options for a grid view that should be passed to
|
||||
/// [`Grid::new()`](struct.Grid.html#method.new).
|
||||
#[derive(PartialEq, Debug)]
|
||||
#[derive(PartialEq, Eq, Debug)]
|
||||
pub struct GridOptions {
|
||||
/// The direction that the cells should be written in — either
|
||||
/// across, or downwards.
|
||||
@@ -218,7 +218,7 @@ pub struct GridOptions {
|
||||
pub filling: Filling,
|
||||
}
|
||||
|
||||
#[derive(PartialEq, Debug)]
|
||||
#[derive(PartialEq, Eq, Debug)]
|
||||
struct Dimensions {
|
||||
/// The number of lines in the grid.
|
||||
num_lines: Width,
|
||||
|
Reference in New Issue
Block a user