From e5d9f405dbdbb033f46cdae4a1832edd782b03fa Mon Sep 17 00:00:00 2001
From: Darren Schroeder <343840+fdncred@users.noreply.github.com>
Date: Thu, 30 Nov 2023 15:00:47 -0600
Subject: [PATCH] add some tests for `stor create` (#11194)

# Description

This is a PR to start adding a few tests to the `stor` commands. It
refactors the `stor create` command so it's easier to write tests.

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
---
 crates/nu-command/src/stor/create.rs | 230 ++++++++++++++++++---------
 1 file changed, 158 insertions(+), 72 deletions(-)

diff --git a/crates/nu-command/src/stor/create.rs b/crates/nu-command/src/stor/create.rs
index 88db8db5b8..6ed0255cf1 100644
--- a/crates/nu-command/src/stor/create.rs
+++ b/crates/nu-command/src/stor/create.rs
@@ -62,83 +62,93 @@ impl Command for StorCreate {
         let columns: Option<Record> = call.get_flag(engine_state, stack, "columns")?;
         let db = Box::new(SQLiteDatabase::new(std::path::Path::new(MEMORY_DB), None));
 
-        if table_name.is_none() {
-            return Err(ShellError::MissingParameter {
-                param_name: "requires at table name".into(),
-                span,
-            });
-        }
-        let new_table_name = table_name.unwrap_or("table".into());
-        if let Ok(conn) = db.open_connection() {
-            match columns {
-                Some(record) => {
-                    let mut create_stmt = format!(
-                        "CREATE TABLE {} ( id INTEGER NOT NULL PRIMARY KEY, ",
-                        new_table_name
-                    );
-                    for (column_name, column_datatype) in record {
-                        match column_datatype.as_string()?.as_str() {
-                            "int" => {
-                                create_stmt.push_str(&format!("{} INTEGER, ", column_name));
-                            }
-                            "float" => {
-                                create_stmt.push_str(&format!("{} REAL, ", column_name));
-                            }
-                            "str" => {
-                                create_stmt.push_str(&format!("{} VARCHAR(255), ", column_name));
-                            }
-
-                            "bool" => {
-                                create_stmt.push_str(&format!("{} BOOLEAN, ", column_name));
-                            }
-                            "datetime" => {
-                                create_stmt.push_str(&format!(
-                                    "{} DATETIME DEFAULT(STRFTIME('%Y-%m-%d %H:%M:%f', 'NOW')), ",
-                                    column_name
-                                ));
-                            }
-
-                            _ => {
-                                return Err(ShellError::UnsupportedInput {
-                                    msg: "unsupported column data type".into(),
-                                    input: format!("{:?}", column_datatype),
-                                    msg_span: column_datatype.span(),
-                                    input_span: column_datatype.span(),
-                                });
-                            }
-                        }
-                    }
-                    if create_stmt.ends_with(", ") {
-                        create_stmt.pop();
-                        create_stmt.pop();
-                    }
-                    create_stmt.push_str(" )");
-
-                    // dbg!(&create_stmt);
-
-                    conn.execute(&create_stmt, []).map_err(|err| {
-                        ShellError::GenericError(
-                            "Failed to open SQLite connection in memory from create".into(),
-                            err.to_string(),
-                            Some(Span::test_data()),
-                            None,
-                            Vec::new(),
-                        )
-                    })?;
-                }
-                None => {
-                    return Err(ShellError::MissingParameter {
-                        param_name: "requires at least one column".into(),
-                        span: call.head,
-                    });
-                }
-            };
-        }
+        process(table_name, span, &db, columns)?;
         // dbg!(db.clone());
         Ok(Value::custom_value(db, span).into_pipeline_data())
     }
 }
 
+fn process(
+    table_name: Option<String>,
+    span: Span,
+    db: &SQLiteDatabase,
+    columns: Option<Record>,
+) -> Result<(), ShellError> {
+    if table_name.is_none() {
+        return Err(ShellError::MissingParameter {
+            param_name: "requires at table name".into(),
+            span,
+        });
+    }
+    let new_table_name = table_name.unwrap_or("table".into());
+    if let Ok(conn) = db.open_connection() {
+        match columns {
+            Some(record) => {
+                let mut create_stmt = format!(
+                    "CREATE TABLE {} ( id INTEGER NOT NULL PRIMARY KEY, ",
+                    new_table_name
+                );
+                for (column_name, column_datatype) in record {
+                    match column_datatype.as_string()?.as_str() {
+                        "int" => {
+                            create_stmt.push_str(&format!("{} INTEGER, ", column_name));
+                        }
+                        "float" => {
+                            create_stmt.push_str(&format!("{} REAL, ", column_name));
+                        }
+                        "str" => {
+                            create_stmt.push_str(&format!("{} VARCHAR(255), ", column_name));
+                        }
+
+                        "bool" => {
+                            create_stmt.push_str(&format!("{} BOOLEAN, ", column_name));
+                        }
+                        "datetime" => {
+                            create_stmt.push_str(&format!(
+                                "{} DATETIME DEFAULT(STRFTIME('%Y-%m-%d %H:%M:%f', 'NOW')), ",
+                                column_name
+                            ));
+                        }
+
+                        _ => {
+                            return Err(ShellError::UnsupportedInput {
+                                msg: "unsupported column data type".into(),
+                                input: format!("{:?}", column_datatype),
+                                msg_span: column_datatype.span(),
+                                input_span: column_datatype.span(),
+                            });
+                        }
+                    }
+                }
+                if create_stmt.ends_with(", ") {
+                    create_stmt.pop();
+                    create_stmt.pop();
+                }
+                create_stmt.push_str(" )");
+
+                // dbg!(&create_stmt);
+
+                conn.execute(&create_stmt, []).map_err(|err| {
+                    ShellError::GenericError(
+                        "Failed to open SQLite connection in memory from create".into(),
+                        err.to_string(),
+                        Some(Span::test_data()),
+                        None,
+                        Vec::new(),
+                    )
+                })?;
+            }
+            None => {
+                return Err(ShellError::MissingParameter {
+                    param_name: "requires at least one column".into(),
+                    span,
+                });
+            }
+        };
+    }
+    Ok(())
+}
+
 #[cfg(test)]
 mod test {
     use super::*;
@@ -149,4 +159,80 @@ mod test {
 
         test_examples(StorCreate {})
     }
+
+    #[test]
+    fn test_process_with_valid_parameters() {
+        let table_name = Some("test_table".to_string());
+        let span = Span::unknown();
+        let db = Box::new(SQLiteDatabase::new(std::path::Path::new(MEMORY_DB), None));
+        let mut columns = Record::new();
+        columns.insert(
+            "int_column".to_string(),
+            Value::test_string("int".to_string()),
+        );
+
+        let result = process(table_name, span, &db, Some(columns));
+
+        assert!(result.is_ok());
+    }
+
+    #[test]
+    fn test_process_with_missing_table_name() {
+        let table_name = None;
+        let span = Span::unknown();
+        let db = Box::new(SQLiteDatabase::new(std::path::Path::new(MEMORY_DB), None));
+        let mut columns = Record::new();
+        columns.insert(
+            "int_column".to_string(),
+            Value::test_string("int".to_string()),
+        );
+
+        let result = process(table_name, span, &db, Some(columns));
+
+        assert!(result.is_err());
+        assert!(result
+            .unwrap_err()
+            .to_string()
+            .contains("requires at table name"));
+    }
+
+    #[test]
+    fn test_process_with_missing_columns() {
+        let table_name = Some("test_table".to_string());
+        let span = Span::unknown();
+        let db = Box::new(SQLiteDatabase::new(std::path::Path::new(MEMORY_DB), None));
+
+        let result = process(table_name, span, &db, None);
+
+        assert!(result.is_err());
+        assert!(result
+            .unwrap_err()
+            .to_string()
+            .contains("requires at least one column"));
+    }
+
+    #[test]
+    fn test_process_with_unsupported_column_data_type() {
+        let table_name = Some("test_table".to_string());
+        let span = Span::unknown();
+        let db = Box::new(SQLiteDatabase::new(std::path::Path::new(MEMORY_DB), None));
+        let mut columns = Record::new();
+        let column_datatype = "bogus_data_type".to_string();
+        columns.insert(
+            "column0".to_string(),
+            Value::test_string(column_datatype.clone()),
+        );
+
+        let result = process(table_name, span, &db, Some(columns));
+
+        assert!(result.is_err());
+
+        let expected_err = ShellError::UnsupportedInput {
+            msg: "unsupported column data type".into(),
+            input: format!("{:?}", column_datatype.clone()),
+            msg_span: Span::test_data(),
+            input_span: Span::test_data(),
+        };
+        assert_eq!(result.unwrap_err().to_string(), expected_err.to_string());
+    }
 }