Use nightly clippy to kill dead code/fix style (#12334)

- **Remove duplicated imports**
- **Remove unused field in `CompletionOptions`**
- **Remove unused struct in `nu-table`**
- **Clarify generic bounds**
- **Simplify a subtrait bound for `ExactSizeIterator`**
- **Use `unwrap_or_default`**
- **Use `Option` directly instead of empty string**
- **Elide unneeded clone in `to html`**
This commit is contained in:
Stefan Holderbach
2024-03-30 02:17:28 +01:00
committed by GitHub
parent ff2aba7ae3
commit e889679d42
17 changed files with 46 additions and 84 deletions

View File

@@ -318,9 +318,9 @@ where
type Ok = ();
type Error = Error;
fn serialize_element<T: ?Sized>(&mut self, value: &T) -> Result<()>
fn serialize_element<T>(&mut self, value: &T) -> Result<()>
where
T: serde::Serialize,
T: serde::Serialize + ?Sized,
{
self.ser
.formatter
@@ -345,9 +345,9 @@ where
type Ok = ();
type Error = Error;
fn serialize_element<T: ?Sized>(&mut self, value: &T) -> Result<()>
fn serialize_element<T>(&mut self, value: &T) -> Result<()>
where
T: serde::Serialize,
T: serde::Serialize + ?Sized,
{
ser::SerializeSeq::serialize_element(self, value)
}
@@ -365,9 +365,9 @@ where
type Ok = ();
type Error = Error;
fn serialize_field<T: ?Sized>(&mut self, value: &T) -> Result<()>
fn serialize_field<T>(&mut self, value: &T) -> Result<()>
where
T: serde::Serialize,
T: serde::Serialize + ?Sized,
{
ser::SerializeSeq::serialize_element(self, value)
}
@@ -385,9 +385,9 @@ where
type Ok = ();
type Error = Error;
fn serialize_field<T: ?Sized>(&mut self, value: &T) -> Result<()>
fn serialize_field<T>(&mut self, value: &T) -> Result<()>
where
T: serde::Serialize,
T: serde::Serialize + ?Sized,
{
ser::SerializeSeq::serialize_element(self, value)
}
@@ -409,9 +409,9 @@ where
type Ok = ();
type Error = Error;
fn serialize_key<T: ?Sized>(&mut self, key: &T) -> Result<()>
fn serialize_key<T>(&mut self, key: &T) -> Result<()>
where
T: serde::Serialize,
T: serde::Serialize + ?Sized,
{
self.ser
.formatter
@@ -423,9 +423,9 @@ where
self.ser.formatter.colon(&mut self.ser.writer)
}
fn serialize_value<T: ?Sized>(&mut self, value: &T) -> Result<()>
fn serialize_value<T>(&mut self, value: &T) -> Result<()>
where
T: serde::Serialize,
T: serde::Serialize + ?Sized,
{
value.serialize(&mut *self.ser)
}
@@ -446,9 +446,9 @@ where
type Ok = ();
type Error = Error;
fn serialize_field<T: ?Sized>(&mut self, key: &'static str, value: &T) -> Result<()>
fn serialize_field<T>(&mut self, key: &'static str, value: &T) -> Result<()>
where
T: serde::Serialize,
T: serde::Serialize + ?Sized,
{
ser::SerializeMap::serialize_entry(self, key, value)
}
@@ -466,9 +466,9 @@ where
type Ok = ();
type Error = Error;
fn serialize_field<T: ?Sized>(&mut self, key: &'static str, value: &T) -> Result<()>
fn serialize_field<T>(&mut self, key: &'static str, value: &T) -> Result<()>
where
T: serde::Serialize,
T: serde::Serialize + ?Sized,
{
ser::SerializeStruct::serialize_field(self, key, value)
}

View File

@@ -2,7 +2,7 @@
use std::collections::{btree_map, BTreeMap};
#[cfg(feature = "preserve_order")]
use linked_hash_map::{self, LinkedHashMap};
use linked_hash_map::LinkedHashMap;
use std::fmt;
use std::io;
@@ -1094,9 +1094,9 @@ impl<'de> de::MapAccess<'de> for MapDeserializer {
}
}
pub fn to_value<T: ?Sized>(value: &T) -> Result<Value>
pub fn to_value<T>(value: &T) -> Result<Value>
where
T: ser::Serialize,
T: ser::Serialize + ?Sized,
{
value.serialize(Serializer)
}