extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 20:47:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve empty pipelines (#7383)

Browse Source 
# Description

This fix changes pipelines to allow them to actually be empty. Mapping
over empty pipelines gives empty pipelines. Empty pipelines immediately
return `None` when iterated.

This removes a some of where `Span::new(0, 0)` was coming from, though
there are other cases where we still use it.

# User-Facing Changes

None

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
JT
2022-12-08 07:31:57 +13:00
committed by GitHub
parent d18587330a
commit eaec480f42
80 changed files with 194 additions and 190 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
crates/nu-command/src/network/fetch.rs
View File

@ -176,7 +176,7 @@ impl Command for SubCommand {
file.flush()?
}
Ok(PipelineData::new(span))
Ok(PipelineData::empty())
}
Value::Binary { val, .. } => {
if let Err(err) = file.write_all(&val) {
@ -185,7 +185,7 @@ impl Command for SubCommand {
file.flush()?
}
Ok(PipelineData::new(span))
Ok(PipelineData::empty())
}
Value::List { vals, .. } => {
let val = vals
@ -201,7 +201,7 @@ impl Command for SubCommand {
file.flush()?
}
Ok(PipelineData::new(span))
Ok(PipelineData::empty())
}
v => Err(ShellError::UnsupportedInput(
format!("{:?} not supported", v.get_type()),
@ -211,7 +211,7 @@ impl Command for SubCommand {
} else {
match value {
PipelineData::ExternalStream { stdout: None, .. } => {
Ok(PipelineData::new(span))
Ok(PipelineData::empty())
}
PipelineData::ExternalStream {
stdout: Some(mut stream),
@ -240,7 +240,7 @@ impl Command for SubCommand {
}
Ok(())
})
.map(|_| PipelineData::new(span))
.map(|_| PipelineData::empty())
}
value => match value.into_value(span) {
Value::String { val, .. } => {
@ -250,7 +250,7 @@ impl Command for SubCommand {
file.flush()?
}
Ok(PipelineData::new(span))
Ok(PipelineData::empty())
}
Value::Binary { val, .. } => {
if let Err(err) = file.write_all(&val) {
@ -259,7 +259,7 @@ impl Command for SubCommand {
file.flush()?
}
Ok(PipelineData::new(span))
Ok(PipelineData::empty())
}
Value::List { vals, .. } => {
let val = vals
@ -275,7 +275,7 @@ impl Command for SubCommand {
file.flush()?
}
Ok(PipelineData::new(span))
Ok(PipelineData::empty())
}
v => Err(ShellError::UnsupportedInput(
format!("{:?} not supported", v.get_type()),