add --signed flag for binary into int conversions (#11902)

<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx

you can also mention related issues, PRs or discussions!
-->

# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.

Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
- adds a `--signed` flag to `into int` to allow parsing binary values as
signed integers, the integer size depends on the length of the binary
value

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
- attempting to convert binary values larger than 8 bytes into integers
now throws an error, with or without `--signed`

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
- wrote 3 tests and 1 example for `into int --signed` usage
- added an example for unsigned binary `into int`

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
- will add examples from this PR to `into int` documentation
This commit is contained in:
moonlander
2024-02-27 15:05:26 +00:00
committed by GitHub
parent 0aae485395
commit ecaed7f0ae
3 changed files with 111 additions and 11 deletions

View File

@ -23,3 +23,21 @@ fn convert_into_int_big_endian() {
let actual = nu!(r#"0x[01 00 00 00 00 00 00 00] | into int --endian big"#);
assert_eq!(actual.out, "72057594037927936");
}
#[test]
fn convert_into_signed_int_little_endian() {
let actual = nu!(r#"0x[ff 00 00 00 00 00 00 00] | into int --endian little --signed"#);
assert_eq!(actual.out, "255");
let actual = nu!(r#"0x[00 00 00 00 00 00 00 ff] | into int --endian little --signed"#);
assert_eq!(actual.out, "-72057594037927936");
}
#[test]
fn convert_into_signed_int_big_endian() {
let actual = nu!(r#"0x[00 00 00 00 00 00 00 ff] | into int --endian big"#);
assert_eq!(actual.out, "255");
let actual = nu!(r#"0x[ff 00 00 00 00 00 00 00] | into int --endian big"#);
assert_eq!(actual.out, "-72057594037927936");
}

View File

@ -31,6 +31,41 @@ fn into_int_binary() {
assert!(actual.out.contains("16843009"));
}
#[test]
fn into_int_binary_signed() {
let actual = nu!("echo 0x[f0] | into int --signed");
assert!(actual.out.contains("-16"));
}
#[test]
fn into_int_binary_back_and_forth() {
let actual = nu!("echo 0x[f0] | into int | into binary | to nuon");
assert!(actual.out.contains("0x[F000000000000000]"));
}
#[test]
fn into_int_binary_signed_back_and_forth() {
let actual = nu!("echo 0x[f0] | into int --signed | into binary | to nuon");
assert!(actual.out.contains("0x[F0FFFFFFFFFFFFFF]"));
}
#[test]
fn into_int_binary_empty() {
let actual = nu!("echo 0x[] | into int");
assert!(actual.out.contains('0'))
}
#[test]
fn into_int_binary_signed_empty() {
let actual = nu!("echo 0x[] | into int --signed");
assert!(actual.out.contains('0'))
}
#[test]
#[ignore]
fn into_int_datetime1() {