Conditionally disable expansion for external command (#6014)

* Fix 5978

* Add unit test for explicit glob

* Format

* Expansion vs none-expansion

* Add unit tests

* Fix format..

* Add debug message for MacOS

* Fix UT on Mac and add tests for windows

* cleanup

* clean up windows test

* single and double qoutes tests

* format...

* Save format.

* Add log to failed windows unit tests

* try `touch` a file

* PS or CMD

* roll back some change

* format

* Remove log and test case

* Add unit test comments

* Fix

Co-authored-by: Frank <v-frankz@microsoft.com>

crates/nu-command/tests/commands/run_external.rs

@@ -1,3 +1,5 @@
+use nu_test_support::fs::Stub::EmptyFile;
+use nu_test_support::playground::Playground;
 use nu_test_support::{nu, pipeline};
 
 #[test]
@@ -13,3 +15,217 @@ fn better_empty_redirection() {
 
     assert!(!actual.out.contains('2'));
 }
+
+#[cfg(not(windows))]
+#[test]
+fn explicit_glob() {
+    Playground::setup("external with explicit glob", |dirs, sandbox| {
+        sandbox.with_files(vec![
+            EmptyFile("D&D_volume_1.txt"),
+            EmptyFile("D&D_volume_2.txt"),
+            EmptyFile("foo.sh"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ^ls | glob '*.txt' | length
+            "#
+        ));
+
+        assert_eq!(actual.out, "2");
+    })
+}
+
+#[cfg(not(windows))]
+#[test]
+fn bare_word_expand_path_glob() {
+    Playground::setup("bare word should do the expansion", |dirs, sandbox| {
+        sandbox.with_files(vec![
+            EmptyFile("D&D_volume_1.txt"),
+            EmptyFile("D&D_volume_2.txt"),
+            EmptyFile("foo.sh"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ^ls *.txt
+            "#
+        ));
+
+        assert!(actual.out.contains("D&D_volume_1.txt"));
+        assert!(actual.out.contains("D&D_volume_2.txt"));
+    })
+}
+
+#[cfg(not(windows))]
+#[test]
+fn backtick_expand_path_glob() {
+    Playground::setup("backtick should do the expansion", |dirs, sandbox| {
+        sandbox.with_files(vec![
+            EmptyFile("D&D_volume_1.txt"),
+            EmptyFile("D&D_volume_2.txt"),
+            EmptyFile("foo.sh"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ^ls `*.txt`
+            "#
+        ));
+
+        assert!(actual.out.contains("D&D_volume_1.txt"));
+        assert!(actual.out.contains("D&D_volume_2.txt"));
+    })
+}
+
+#[cfg(not(windows))]
+#[test]
+fn single_quote_does_not_expand_path_glob() {
+    Playground::setup("single quote do not run the expansion", |dirs, sandbox| {
+        sandbox.with_files(vec![
+            EmptyFile("D&D_volume_1.txt"),
+            EmptyFile("D&D_volume_2.txt"),
+            EmptyFile("foo.sh"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ^ls '*.txt'
+            "#
+        ));
+
+        assert!(actual.err.contains("No such file or directory"));
+    })
+}
+
+#[cfg(not(windows))]
+#[test]
+fn double_quote_does_not_expand_path_glob() {
+    Playground::setup("double quote do not run the expansion", |dirs, sandbox| {
+        sandbox.with_files(vec![
+            EmptyFile("D&D_volume_1.txt"),
+            EmptyFile("D&D_volume_2.txt"),
+            EmptyFile("foo.sh"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ^ls "*.txt"
+            "#
+        ));
+
+        assert!(actual.err.contains("No such file or directory"));
+    })
+}
+
+#[cfg(windows)]
+#[test]
+fn explicit_glob_windows() {
+    Playground::setup("external with explicit glob", |dirs, sandbox| {
+        sandbox.with_files(vec![
+            EmptyFile("D&D_volume_1.txt"),
+            EmptyFile("D&D_volume_2.txt"),
+            EmptyFile("foo.sh"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ^dir | glob '*.txt' | length
+            "#
+        ));
+
+        assert_eq!(actual.out, "2");
+    })
+}
+
+#[cfg(windows)]
+#[test]
+fn bare_word_expand_path_glob_windows() {
+    Playground::setup("bare word should do the expansion", |dirs, sandbox| {
+        sandbox.with_files(vec![
+            EmptyFile("D&D_volume_1.txt"),
+            EmptyFile("D&D_volume_2.txt"),
+            EmptyFile("foo.sh"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ^dir *.txt
+            "#
+        ));
+
+        assert!(actual.out.contains("D&D_volume_1.txt"));
+        assert!(actual.out.contains("D&D_volume_2.txt"));
+    })
+}
+
+#[cfg(windows)]
+#[test]
+// This test case might fail based on the running shell on Windows - CMD vs PowerShell, the reason is
+//
+// Test command 1 - `dir * `
+// Test command 2 - `dir '*'`
+// Test command 3 - `dir "*"`
+//
+// In CMD, command 2 and 3 will give you an error of 'File Not Found'
+// In Poweshell, all three commands will do the path expansion with any errors whatsoever
+//
+// With current Windows CI build(Microsoft Windows 2022 with version 10.0.20348),
+// the unit test runs agaisnt PowerShell
+fn double_quote_does_not_expand_path_glob_windows() {
+    Playground::setup("double quote do not run the expansion", |dirs, sandbox| {
+        sandbox.with_files(vec![
+            EmptyFile("D&D_volume_1.txt"),
+            EmptyFile("D&D_volume_2.txt"),
+            EmptyFile("foo.sh"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                dir "*.txt"
+            "#
+        ));
+        assert!(actual.out.contains("D&D_volume_1.txt"));
+        assert!(actual.out.contains("D&D_volume_2.txt"));
+    })
+}
+
+#[cfg(windows)]
+#[test]
+// This test case might fail based on the running shell on Windows - CMD vs PowerShell, the reason is
+//
+// Test command 1 - `dir * `
+// Test command 2 - `dir '*'`
+// Test command 3 - `dir "*"`
+//
+// In CMD, command 2 and 3 will give you an error of 'File Not Found'
+// In Poweshell, all three commands will do the path expansion with any errors whatsoever
+//
+// With current Windows CI build(Microsoft Windows 2022 with version 10.0.20348),
+// the unit test runs agaisnt PowerShell
+fn single_quote_does_not_expand_path_glob_windows() {
+    Playground::setup("single quote do not run the expansion", |dirs, sandbox| {
+        sandbox.with_files(vec![
+            EmptyFile("D&D_volume_1.txt"),
+            EmptyFile("D&D_volume_2.txt"),
+            EmptyFile("foo.sh"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                dir '*.txt'
+            "#
+        ));
+        assert!(actual.out.contains("D&D_volume_1.txt"));
+        assert!(actual.out.contains("D&D_volume_2.txt"));
+    });
+}